Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_preprocessor): add crop_boxes_filter_node to handle multiple cropbox inputs #6402

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Feb 14, 2024

Description

Objective

#6401

This PR tries to add new crop box filter node that can handle multiple cropbox inputs.

Related links

#6401

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Feb 14, 2024
@YoshiRi YoshiRi marked this pull request as draft February 14, 2024 06:19
@YoshiRi YoshiRi force-pushed the feat/add_cropboxes_filter branch from 560ee5a to 825ef9e Compare February 14, 2024 12:25
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Feb 14, 2024

performance comparison

latency check

It seems that there are only very slight changes between cropboxes filter and conventional two filter 😮‍💨

after before
image image

statistics:

<style type="text/css"></style>

cropbox filter min max average
after 90.875778 127.253656 108.283442
before 95.797686 130.331491 108.670043
       
distortion corrector min max average
after 90.875778 127.253656 108.432368
before 96.087639 130.331491 110.542288

check from processing time

By checking processing time, it seems this PR can save several ms compared with conventional processing

image

Copy link

stale bot commented Apr 16, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Apr 16, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Aug 13, 2024
Copy link

stale bot commented Oct 19, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant