Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_tracks_msgs_converter): add a missing parameter 'new_frame_id' #6408

Conversation

technolojin
Copy link
Contributor

Description

add a missing parameter 'new_frame_id'

Tests performed

Tested on a TIER IV logging simulator environment.

Effects on system behavior

Able to launch radar_tracks_msgs_converter.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 14, 2024
@technolojin technolojin self-assigned this Feb 14, 2024
@technolojin technolojin marked this pull request as ready for review February 14, 2024 10:12
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78eea31) 14.84% compared to head (56e4190) 14.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6408   +/-   ##
=======================================
  Coverage   14.84%   14.84%           
=======================================
  Files        1838     1838           
  Lines      126712   126712           
  Branches    37976    37976           
=======================================
  Hits        18816    18816           
  Misses      86649    86649           
  Partials    21247    21247           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.84% <ø> (ø) Carriedforward from 78eea31

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miursh miursh merged commit 28154f6 into autowarefoundation:main Feb 14, 2024
31 of 33 checks passed
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@technolojin technolojin deleted the fix/radar_trackes_converter_missing_param branch July 26, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants