-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(image_projection_based_fusion): fix bug #6411
fix(image_projection_based_fusion): fix bug #6411
Conversation
Signed-off-by: kminoda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6411 +/- ##
==========================================
- Coverage 14.84% 14.82% -0.03%
==========================================
Files 1838 1843 +5
Lines 126712 126948 +236
Branches 37976 37974 -2
==========================================
Hits 18816 18816
- Misses 86649 86887 +238
+ Partials 21247 21245 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can only see pipeline_latency_ms
from roi_cluster_fusion
and roi_detected_object_fusion
/perception/object_recognition/detection/clustering/camera_lidar_fusion/roi_cluster_fusion
-> /perception/object_recognition/detection/clustering/camera_lidar_fusion/image_projection_based_fusion/debug/pipeline_latency_ms
/perception/object_recognition/detection/clustering/roi_pointcloud_fusion
-> no pipeline_latency_ms
/perception/object_recognition/detection/pointpainting/pointpainting
-> no pipeline_latency_ms
/perception/object_recognition/detection/roi_detected_object_fusion
-> /perception/object_recognition/detection/image_projection_based_fusion/debug/pipeline_latency_ms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Description
Fix a bug in #6181
Tests performed
Tested with Autoware w/ following packages:
Effects on system behavior
Bug fixed
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.