Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image_projection_based_fusion): fix bug #6411

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Feb 14, 2024

Description

Fix a bug in #6181

Tests performed

Tested with Autoware w/ following packages:

  • pointpainting
  • roi_cluster_fusion
  • roi_detected_object_fusion
  • roi_pointcloud_fusion

Effects on system behavior

Bug fixed

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 14, 2024
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 14, 2024
@kminoda kminoda marked this pull request as ready for review February 14, 2024 12:36
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78eea31) 14.84% compared to head (fa07107) 14.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6411      +/-   ##
==========================================
- Coverage   14.84%   14.82%   -0.03%     
==========================================
  Files        1838     1843       +5     
  Lines      126712   126948     +236     
  Branches    37976    37974       -2     
==========================================
  Hits        18816    18816              
- Misses      86649    86887     +238     
+ Partials    21247    21245       -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.84% <ø> (+<0.01%) ⬆️ Carriedforward from 78eea31

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only see pipeline_latency_ms from roi_cluster_fusion and roi_detected_object_fusion

/perception/object_recognition/detection/clustering/camera_lidar_fusion/roi_cluster_fusion
-> /perception/object_recognition/detection/clustering/camera_lidar_fusion/image_projection_based_fusion/debug/pipeline_latency_ms

/perception/object_recognition/detection/clustering/roi_pointcloud_fusion
-> no pipeline_latency_ms

/perception/object_recognition/detection/pointpainting/pointpainting
-> no pipeline_latency_ms

/perception/object_recognition/detection/roi_detected_object_fusion
-> /perception/object_recognition/detection/image_projection_based_fusion/debug/pipeline_latency_ms

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 1dac00b into autowarefoundation:main Feb 14, 2024
27 of 29 checks passed
@kminoda kminoda deleted the fix/image_projection_based_fusion/fix_bug branch February 15, 2024 00:37
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants