Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json-schema-check): update schemas #6474

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Feb 21, 2024

Description

Part of:

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Feb 21, 2024
@xmfcx xmfcx force-pushed the fix/json-schema-check-general branch from d3a10aa to 374b74b Compare February 21, 2024 17:14
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 21, 2024
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Feb 21, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 21, 2024

CI is green 🙂 https://github.com/autowarefoundation/autoware.universe/actions/runs/7993331975/job/21828904972#step:3:43

But I see that there are some contested problems. I will separate them out of this PR, only leave the simple changes here.

@xmfcx xmfcx force-pushed the fix/json-schema-check-general branch from 595b256 to fa216df Compare February 21, 2024 17:53
@xmfcx xmfcx changed the title fix(json-schema-check): fix parameters and schema files fix(json-schema-check): update schemas Feb 21, 2024
@github-actions github-actions bot removed component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Feb 21, 2024
@xmfcx xmfcx self-assigned this Feb 21, 2024
@xmfcx xmfcx added DevOps Dojo: ROS Node Conf Related to Open AD Kit WG run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Feb 21, 2024
@xmfcx xmfcx marked this pull request as ready for review February 21, 2024 17:55
@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 21, 2024

I have only updated the schema files on this PR, makes the CI greener than before:

Before:

After:

Very easy to review, there shouldn't be any risk.

@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 21, 2024

And @badai-nguyen could you review the compare_map_segmentation schema updates?

Since you have also reviewed:

cc. @yuntianyi-chen

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1397e91) 14.64% compared to head (48bc7b0) 14.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6474   +/-   ##
=======================================
  Coverage   14.64%   14.64%           
=======================================
  Files        1899     1899           
  Lines      130283   130283           
  Branches    38311    38311           
=======================================
  Hits        19080    19080           
  Misses      89786    89786           
  Partials    21417    21417           
Flag Coverage Δ *Carryforward flag
differential 6.25% <ø> (?)
total 14.64% <ø> (ø) Carriedforward from 1397e91

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx force-pushed the fix/json-schema-check-general branch from fa216df to 60fcb92 Compare February 22, 2024 11:38
@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 22, 2024

@badai-nguyen could you review the compare_map_segmentation part please?

@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 23, 2024

@badai-nguyen could you review the compare_map_segmentation part please?

@xmfcx
Copy link
Contributor Author

xmfcx commented Feb 23, 2024

Thank you so much!

@xmfcx xmfcx merged commit b86a00d into main Feb 23, 2024
24 of 25 checks passed
@xmfcx xmfcx deleted the fix/json-schema-check-general branch February 23, 2024 13:48
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) DevOps Dojo: ROS Node Conf Related to Open AD Kit WG run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants