-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(json-schema-check): update schemas #6474
Conversation
d3a10aa
to
374b74b
Compare
CI is green 🙂 https://github.com/autowarefoundation/autoware.universe/actions/runs/7993331975/job/21828904972#step:3:43 But I see that there are some contested problems. I will separate them out of this PR, only leave the simple changes here. |
595b256
to
fa216df
Compare
I have only updated the schema files on this PR, makes the CI greener than before: Before: After: Very easy to review, there shouldn't be any risk. |
planning/behavior_velocity_planner/schema/behavior_velocity_planner.schema.json
Outdated
Show resolved
Hide resolved
And @badai-nguyen could you review the compare_map_segmentation schema updates? Since you have also reviewed: cc. @yuntianyi-chen |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6474 +/- ##
=======================================
Coverage 14.64% 14.64%
=======================================
Files 1899 1899
Lines 130283 130283
Branches 38311 38311
=======================================
Hits 19080 19080
Misses 89786 89786
Partials 21417 21417
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
fa216df
to
60fcb92
Compare
@badai-nguyen could you review the compare_map_segmentation part please? |
planning/behavior_velocity_planner/schema/behavior_velocity_planner.schema.json
Outdated
Show resolved
Hide resolved
@badai-nguyen could you review the compare_map_segmentation part please? |
Thank you so much! |
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Description
Part of:
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.