Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ndt_scan_matcher): add a bool return indicating whether ndt has been updated in update_ndt #6502

Merged

Conversation

SakodaShintaro
Copy link
Contributor

Description

Context

In the current implementation, the process continues even if there is no change in update_ndt, then the pointer is switched, and the original ndt object is destroyed.
I'm not sure which thread calls the NDT destructor when it is destroyed, but it has a negative impact on the overall operation of NDT.

Changes

  • Add a bool return indicating whether ndt has been updated in update_ndt.
  • Use this return value to switch the behavior in update_map.

Tests performed

It has been confirmed that the logging_simulator runs with the same accuracy as before on AWSIM data with GT.

  • single pcd
  • multi pcd

I confirmed that it works properly with AWSIM as well.

Effects on system behavior

There are no effects on system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 27, 2024
@SakodaShintaro SakodaShintaro self-assigned this Feb 27, 2024
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Feb 27, 2024
@SakodaShintaro SakodaShintaro marked this pull request as ready for review February 27, 2024 09:05
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 14.72%. Comparing base (4b784b4) to head (0134e4b).
Report is 3 commits behind head on main.

Files Patch % Lines
...ization/ndt_scan_matcher/src/map_update_module.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6502      +/-   ##
==========================================
- Coverage   14.72%   14.72%   -0.01%     
==========================================
  Files        1900     1900              
  Lines      130361   130363       +2     
  Branches    38381    38382       +1     
==========================================
  Hits        19198    19198              
- Misses      89647    89649       +2     
  Partials    21516    21516              
Flag Coverage Δ *Carryforward flag
differential 3.65% <0.00%> (?)
total 14.72% <ø> (+<0.01%) ⬆️ Carriedforward from 4b784b4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit 30cd241 into autowarefoundation:main Feb 28, 2024
29 of 33 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/update_ndt branch February 28, 2024 01:23
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…een updated in update_ndt (#6502)

Fixed update_ndt

Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…een updated in update_ndt (autowarefoundation#6502)

Fixed update_ndt

Signed-off-by: Shintaro Sakoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants