fix(ndt_scan_matcher): add a bool return indicating whether ndt has been updated in update_ndt #6502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
In the current implementation, the process continues even if there is no change in update_ndt, then the pointer is switched, and the original ndt object is destroyed.
I'm not sure which thread calls the NDT destructor when it is destroyed, but it has a negative impact on the overall operation of NDT.
Changes
Tests performed
It has been confirmed that the
logging_simulator
runs with the same accuracy as before on AWSIM data with GT.I confirmed that it works properly with AWSIM as well.
Effects on system behavior
There are no effects on system behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.