Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build-and-test-differential): remove clang-tidy-differential job #6507

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Feb 28, 2024

Description

Related issue:

This job was optional and I don't ever remember seeing it turn green.

It is also being run on self hosted machines and it is contesting for the limited CI resources.

So I'm removing it and it can be added back once we switch to the public instances again.

Or we can utilize it for the core packages in future.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Feb 28, 2024
@xmfcx xmfcx requested review from mitsudome-r and kminoda February 28, 2024 16:10
@xmfcx xmfcx self-assigned this Feb 28, 2024
@xmfcx xmfcx requested a review from satoshi-ota February 28, 2024 16:12
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 28, 2024
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (totally agreed)

@xmfcx xmfcx merged commit bba42a2 into main Feb 29, 2024
42 checks passed
@xmfcx xmfcx deleted the ci/remove-clang-tidy branch February 29, 2024 06:01
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants