fix(lane_change): approval chatters when no valid paths #6516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
zulfaqar-azmi-t4
force-pushed
the
fix-lane-change-approval-chatter
branch
from
1a773d9 to
8d3cbba
Compare
satoshi-ota
approved these changes
Mar 5, 2024
satoshi-ota
added
the
run:build-and-test-differential
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
force-pushed
the
fix-lane-change-approval-chatter
branch
from
8d3cbba to
e3a34e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6516 +/- ##
=======================================
Coverage 14.78% 14.78%
=======================================
Files 1917 1917
Lines 132038 132035 -3
Branches 39228 39227 -1
=======================================
Hits 19523 19523
+ Misses 90726 90722 -4
- Partials 21789 21790 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 5, 2024
…dation#6516) Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
4 tasks
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 7, 2024
…dation#6516) Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…dation#6516) Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: kaigohirao <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…dation#6516) Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix approval chatter when lane change is running while no valid path is available
Before PR
Screencast.from.2024.02.29.15.51.04.webm
After PR
Screencast.from.2024.02.29.15.47.02.webm
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.