Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(autoware_overlay_rviz_plugin): add missing ament_cmake_auto dependency #6519

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Feb 29, 2024

Description

This PR adds a missing dependency to ament_cmake_auto

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve esteve requested review from KhalilSelyan and xmfcx February 29, 2024 10:01
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 29, 2024
@esteve esteve requested a review from mitsudome-r February 29, 2024 10:01
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 29, 2024
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@esteve esteve enabled auto-merge (squash) February 29, 2024 10:34
@esteve
Copy link
Contributor Author

esteve commented Feb 29, 2024

@xmfcx thanks for the quick review

@esteve esteve merged commit 172a3fc into main Feb 29, 2024
28 checks passed
@esteve esteve deleted the fix-overlay-rviz-plugin-ament-cmake-auto-dependency branch February 29, 2024 12:32
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…endency (#6519)

Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants