Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress spell check failure to ignore LOBF, bcnn, CTRV and DLCPU #6523

Closed
wants to merge 1 commit into from

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Mar 1, 2024

Description

In #6432, json-schema-check is not working for some reasons.
So I recreate.

I fix spell check failures to ignore LOBF, bcnn, CTRV and DLCPU.
I followed ↓.

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta enabled auto-merge (squash) March 1, 2024 01:34
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 1, 2024
@h-ohta h-ohta added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 1, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta
Copy link
Contributor Author

h-ohta commented Mar 1, 2024

I found that json-schema-check is required action but it does not need for this PR because I don't edit schema.json or param.yaml.
https://github.com/autowarefoundation/autoware.universe/blob/main/.github/workflows/json-schema-check.yaml#L3-L8

#6432 does not has any problem, so I reopen it.

@h-ohta h-ohta closed this Mar 1, 2024
auto-merge was automatically disabled March 1, 2024 01:51

Pull request was closed

Copy link

mergify bot commented Mar 1, 2024

⚠️ The sha of the head commit of this PR conflicts with #6432. Mergify cannot evaluate rules on this PR. ⚠️

@mitsudome-r mitsudome-r deleted the fix/ignore_spell_check2 branch June 10, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants