Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(json-schema-check): run only if relevant files are changed #6530

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Mar 1, 2024

Description

Continuation from:

With this restructuring of the actions,

  • pre-check will check if relevant files are changed
    • if yes, json-schema-check will do its thing
    • if not, no-relevant-changes will return successful

Tests performed

Tests are below:

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Mar 1, 2024
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx force-pushed the ci/json-schema-conditional branch from 52f586c to c091d5a Compare March 1, 2024 10:34
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Mar 1, 2024
@xmfcx xmfcx marked this pull request as draft March 1, 2024 10:35
@xmfcx
Copy link
Contributor Author

xmfcx commented Mar 1, 2024

No files changed, skipped, successful.

Screenshot from 2024-03-01 13-41-07


Schema files changed to fail the json-schema-check, failure (as expected).

Screenshot from 2024-03-01 13-36-16


Schema files changed to succeed the json-schema-check, success.

Screenshot from 2024-03-01 13-39-33

Signed-off-by: M. Fatih Cırıt <[email protected]>
@github-actions github-actions bot removed the component:localization Vehicle's position determination in its environment. (auto-assigned) label Mar 1, 2024
@xmfcx xmfcx requested review from ambroise-arm and HansRobo and removed request for TaikiYamada4 March 1, 2024 10:43
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 1, 2024
@xmfcx xmfcx marked this pull request as ready for review March 1, 2024 10:50
Signed-off-by: M. Fatih Cırıt <[email protected]>
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HansRobo HansRobo merged commit 8eafac5 into main Mar 1, 2024
19 checks passed
@HansRobo HansRobo deleted the ci/json-schema-conditional branch March 1, 2024 10:56
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
* ci(json-schema-check): run only if relevant files are changed

Signed-off-by: M. Fatih Cırıt <[email protected]>

* simplify

Signed-off-by: M. Fatih Cırıt <[email protected]>

* temp change to break things to test the action

Signed-off-by: M. Fatih Cırıt <[email protected]>

* temp change to test success of the action

Signed-off-by: M. Fatih Cırıt <[email protected]>

* revert temp changes

Signed-off-by: M. Fatih Cırıt <[email protected]>

* better naming

Signed-off-by: M. Fatih Cırıt <[email protected]>

---------

Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…refoundation#6530)

* ci(json-schema-check): run only if relevant files are changed

Signed-off-by: M. Fatih Cırıt <[email protected]>

* simplify

Signed-off-by: M. Fatih Cırıt <[email protected]>

* temp change to break things to test the action

Signed-off-by: M. Fatih Cırıt <[email protected]>

* temp change to test success of the action

Signed-off-by: M. Fatih Cırıt <[email protected]>

* revert temp changes

Signed-off-by: M. Fatih Cırıt <[email protected]>

* better naming

Signed-off-by: M. Fatih Cırıt <[email protected]>

---------

Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: kaigohirao <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…refoundation#6530)

* ci(json-schema-check): run only if relevant files are changed

Signed-off-by: M. Fatih Cırıt <[email protected]>

* simplify

Signed-off-by: M. Fatih Cırıt <[email protected]>

* temp change to break things to test the action

Signed-off-by: M. Fatih Cırıt <[email protected]>

* temp change to test success of the action

Signed-off-by: M. Fatih Cırıt <[email protected]>

* revert temp changes

Signed-off-by: M. Fatih Cırıt <[email protected]>

* better naming

Signed-off-by: M. Fatih Cırıt <[email protected]>

---------

Signed-off-by: M. Fatih Cırıt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants