-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pointcloud_preprocessor): add pipeline_latency_ms debug publisher to missed modules #6569
feat(pointcloud_preprocessor): add pipeline_latency_ms debug publisher to missed modules #6569
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6569 +/- ##
==========================================
- Coverage 14.78% 14.78% -0.01%
==========================================
Files 1917 1917
Lines 132253 132266 +13
Branches 39297 39297
==========================================
Hits 19550 19550
- Misses 90876 90889 +13
Partials 21827 21827
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…r to missed modules Signed-off-by: Berkay Karaman <[email protected]>
64ba795
to
83a61d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I checked with sample-rosbag with tutorial. (Need to merge sample_sensor_kit_PR )
/sensing/lidar/concatenate_pointclouds_debug/debug/sensing/lidar/left/pointcloud/pipeline_latency_ms
/sensing/lidar/concatenate_pointclouds_debug/debug/sensing/lidar/right/pointcloud/pipeline_latency_ms
/sensing/lidar/concatenate_pointclouds_debug/debug/sensing/lidar/top/pointcloud/pipeline_latency_ms
# also found in time_sync pointclouds
@miursh Could you approve as a owner?
@miursh Sorry to bother you Miura-san. We need an approval from code owners. If you have time, could you check it? |
…r to missed modules (autowarefoundation#6569) Signed-off-by: Berkay Karaman <[email protected]>
…r to missed modules (autowarefoundation#6569) Signed-off-by: Berkay Karaman <[email protected]> Signed-off-by: kaigohirao <[email protected]>
…r to missed modules (autowarefoundation#6569) Signed-off-by: Berkay Karaman <[email protected]>
Description
In the issue above, we discussed that a more efficient method would be for the nodes themselves to report the delays.
I missed adding this debug publisher to concatenate_pointclouds and time_synchronizer.
Tests performed
Tested with e2e_simulator. Works well.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.