-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pointcloud_preprocessor): make concatenate node to publish pointclouds in sensor frame #6586
feat(pointcloud_preprocessor): make concatenate node to publish pointclouds in sensor frame #6586
Conversation
Signed-off-by: yoshiri <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6586 +/- ##
==========================================
+ Coverage 14.80% 14.86% +0.06%
==========================================
Files 1917 1917
Lines 132086 132420 +334
Branches 39262 39407 +145
==========================================
+ Hits 19553 19689 +136
- Misses 90715 90884 +169
- Partials 21818 21847 +29
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yoshiri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…clouds in sensor frame (autowarefoundation#6586) * feat: make concatenate node to publish pointclouds in sensor frame Signed-off-by: yoshiri <[email protected]> * chore: disable frame transform if not necessary Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
…clouds in sensor frame (autowarefoundation#6586) * feat: make concatenate node to publish pointclouds in sensor frame Signed-off-by: yoshiri <[email protected]> * chore: disable frame transform if not necessary Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]> Signed-off-by: kaigohirao <[email protected]>
…clouds in sensor frame (autowarefoundation#6586) * feat: make concatenate node to publish pointclouds in sensor frame Signed-off-by: yoshiri <[email protected]> * chore: disable frame transform if not necessary Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
…clouds in sensor frame (autowarefoundation#6586) * feat: make concatenate node to publish pointclouds in sensor frame Signed-off-by: yoshiri <[email protected]> * chore: disable frame transform if not necessary Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
…clouds in sensor frame (autowarefoundation#6586) * feat: make concatenate node to publish pointclouds in sensor frame Signed-off-by: yoshiri <[email protected]> * chore: disable frame transform if not necessary Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
Description
Related #5485, this PR enables to publish synchronized pointclouds in sensor_frame.
Related links
https://github.com/orgs/autowarefoundation/discussions/4158
Tests performed
Tested with Lsim.
Need to merge autowarefoundation/sample_sensor_kit_launch#84 if you want to test separated concatenate and time sync nodes.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.