Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename autoware_perception_msgs::msg::TrafficSingal** to TrafficLight** #6763

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Apr 8, 2024

Description

PR to change autoware_msgs : autowarefoundation/autoware_msgs#84

TODO: some elements in target messages should be updated

Related links

Tests performed

Notes for reviewers

Interface changes

  • autoware_perception_msgs::msg::TrafficSignal -> autoware_perception_msgs::msg::TrafficLight
  • autoware_perception_msgs::msg::TrafficSignalArray -> autoware_perception_msgs::msg::TrafficLightArrray
  • autoware_perception_msgs::msg::TrafficSingalElement -> autoware_perception_msgs::msg::TrafficLightElement

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

ktro2828 added 18 commits April 9, 2024 03:59
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Apr 8, 2024
@ktro2828 ktro2828 changed the title reafactor!: rename autoware_msgs::msg::TrafficSingal** to TrafficLight** refactor!: rename autoware_msgs::msg::TrafficSingal** to TrafficLight** Apr 8, 2024
@ktro2828 ktro2828 changed the title refactor!: rename autoware_msgs::msg::TrafficSingal** to TrafficLight** refactor!: rename autoware_perception_msgs::msg::TrafficSingal** to TrafficLight** Apr 8, 2024
Copy link

stale bot commented Jun 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 8, 2024
@ktro2828 ktro2828 closed this Jun 9, 2024
@ktro2828 ktro2828 deleted the refactor/traffic_light/rename_msg branch August 8, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant