fix(avoidance): fix bugs in parked vehicle filtering logic #7072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
satoshi-ota
force-pushed
the
fix/on-ego-lane
branch
2 times, most recently
from
f3259f8 to
9d3e6a9
Compare
satoshi-ota
requested review from
rej55,
go-sakayori,
kyoichi-sugahara,
shmpwk,
TakaHoribe,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
shmpwk
added
the
run:build-and-test-differential
satoshi-ota
force-pushed
the
fix/on-ego-lane
branch
from
9d3e6a9 to
060adae
Compare
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
fix/on-ego-lane
branch
from
060adae to
6bd2315
Compare
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…oundation#7072) * fix(avoidance): check prev/next lane Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix parked vehicle filtering Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): check intersection location Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…oundation#7072) * fix(avoidance): check prev/next lane Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix parked vehicle filtering Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): check intersection location Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 13, 2024
…oundation#7072) * fix(avoidance): check prev/next lane Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix parked vehicle filtering Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): check intersection location Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* fix(avoidance): check prev/next lane Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix parked vehicle filtering Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): check intersection location Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes followng bug fixes:
Sometimes, the module didn't judge whether the vehicle was on ego lane properly.
Check if object's lane within/without not only for object's closest lane but also its next/prev lanes.
The module avoided vehicles unexpectedly.
If there was road shoulder lane on left side, the module created avoidance path not only for vehicle whose footprint was on road shoulder lane but also vehicles stopped without pulling over the side of the road.
The module ignored vehicle within virtual intersection for entering private area.
Use location tag to judge if it's a virtual intersection or not.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.