test(image_projection_based_fusion): add test for image_projection_based_fusion's IoU calculation functions #7087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamratThapa120
requested review from
badai-nguyen,
kminoda,
ktro2828,
miursh,
tzhong518,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:perception
|
@SamratThapa120 Thank you for the PR 🎉 |
kminoda
added
the
run:build-and-test-differential
Signed-off-by: samrat.thapa <[email protected]>
Signed-off-by: samrat.thapa <[email protected]>
SamratThapa120
force-pushed
the
test/image_projection_based_fusion/add_calc_iou_tests
branch
from
a245858 to
47fc998
Compare
yukkysaito
reviewed
May 21, 2024
| roi2.width = 4; | ||
| roi2.height = 4; | ||
|
|
||
| double ioux = calcIoUX(roi1, roi2); |
There was a problem hiding this comment.
ioux doesn't seem to be a common term. what about iou_x?
Suggested change
| double ioux = calcIoUX(roi1, roi2); | |
| double iou_x = calcIoUX(roi1, roi2); |
There was a problem hiding this comment.
@yukkysaito Thanks 🙏
@SamratThapa120 FYI, try to fix all the spell-check-partial error as well (which was originally a required CI, but recently it's not somehow ... 🤔 )
Signed-off-by: samrat.thapa <[email protected]>
|
@SamratThapa120 |
|
(sorry, pressed |
SamratThapa120
deleted the
test/image_projection_based_fusion/add_calc_iou_tests
branch
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…sed_fusion's IoU calculation functions (autowarefoundation#7087) * added test for geometry utils iou calculation Signed-off-by: samrat.thapa <[email protected]> * style(pre-commit): autofix * fix pre-commit ci Signed-off-by: samrat.thapa <[email protected]> * fixed spelling errors Signed-off-by: samrat.thapa <[email protected]> --------- Signed-off-by: samrat.thapa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…sed_fusion's IoU calculation functions (autowarefoundation#7087) * added test for geometry utils iou calculation Signed-off-by: samrat.thapa <[email protected]> * style(pre-commit): autofix * fix pre-commit ci Signed-off-by: samrat.thapa <[email protected]> * fixed spelling errors Signed-off-by: samrat.thapa <[email protected]> --------- Signed-off-by: samrat.thapa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…sed_fusion's IoU calculation functions (#7087) * added test for geometry utils iou calculation Signed-off-by: samrat.thapa <[email protected]> * style(pre-commit): autofix * fix pre-commit ci Signed-off-by: samrat.thapa <[email protected]> * fixed spelling errors Signed-off-by: samrat.thapa <[email protected]> --------- Signed-off-by: samrat.thapa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add test for image_projection_based_fusion's IoU calculation functions
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.