Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perception_online_evaluator): revert "add metric_value not only stat (#7100)" #7118

Merged
merged 1 commit into from
May 24, 2024

Conversation

kosuke55
Copy link
Contributor

Reverts #7100

is not yet ready to support in driving_log_replayer. so once revert it.

@kosuke55 kosuke55 marked this pull request as ready for review May 24, 2024 08:17
@kosuke55 kosuke55 changed the title Revert "feat(perception_online_evaluator): add metric_value not only stat" fix(perception_online_evaluator): add metric_value not only stat (#7100)" May 24, 2024
@kosuke55 kosuke55 changed the title fix(perception_online_evaluator): add metric_value not only stat (#7100)" fix(perception_online_evaluator): add metric_value not only stat (#7100) May 24, 2024
@kosuke55 kosuke55 changed the title fix(perception_online_evaluator): add metric_value not only stat (#7100) fix(perception_online_evaluator): revert "add metric_value not only stat (#7100)" May 24, 2024
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label May 24, 2024
@kosuke55 kosuke55 merged commit d827b1b into main May 24, 2024
38 of 40 checks passed
@kosuke55 kosuke55 deleted the revert-7100-feat/metric_value branch May 24, 2024 11:49
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
hayato-m126 pushed a commit that referenced this pull request Jun 7, 2024
…)(#7118) (revert of revert) (#7167)

* Revert "fix(perception_online_evaluator): revert "add metric_value not only s…"

This reverts commit d827b1b.

* Update evaluator/perception_online_evaluator/include/perception_online_evaluator/perception_online_evaluator_node.hpp

* Update evaluator/perception_online_evaluator/src/perception_online_evaluator_node.cpp

* use emplace back

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: Kotaro Uetake <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…)(#7118) (revert of revert) (#7167)

* Revert "fix(perception_online_evaluator): revert "add metric_value not only s…"

This reverts commit d827b1b.

* Update evaluator/perception_online_evaluator/include/perception_online_evaluator/perception_online_evaluator_node.hpp

* Update evaluator/perception_online_evaluator/src/perception_online_evaluator_node.cpp

* use emplace back

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Co-authored-by: Kotaro Uetake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants