-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(perception_online_evaluator): revert "add metric_value not only stat (#7100)" #7118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
rej55,
ktro2828,
kyoichi-sugahara,
miursh and
YoshiRi
as code owners
May 24, 2024 08:17
kosuke55
changed the title
Revert "feat(perception_online_evaluator): add metric_value not only stat"
fix(perception_online_evaluator): add metric_value not only stat (#7100)"
May 24, 2024
kosuke55
changed the title
fix(perception_online_evaluator): add metric_value not only stat (#7100)"
fix(perception_online_evaluator): add metric_value not only stat (#7100)
May 24, 2024
kosuke55
changed the title
fix(perception_online_evaluator): add metric_value not only stat (#7100)
fix(perception_online_evaluator): revert "add metric_value not only stat (#7100)"
May 24, 2024
kosuke55
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
May 24, 2024
rej55
approved these changes
May 24, 2024
github-actions
bot
added
the
component:evaluator
Evaluation tools for planning, localization etc. (auto-assigned)
label
May 24, 2024
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
hayato-m126
pushed a commit
that referenced
this pull request
Jun 7, 2024
…)(#7118) (revert of revert) (#7167) * Revert "fix(perception_online_evaluator): revert "add metric_value not only s…" This reverts commit d827b1b. * Update evaluator/perception_online_evaluator/include/perception_online_evaluator/perception_online_evaluator_node.hpp * Update evaluator/perception_online_evaluator/src/perception_online_evaluator_node.cpp * use emplace back Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Kotaro Uetake <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…)(#7118) (revert of revert) (#7167) * Revert "fix(perception_online_evaluator): revert "add metric_value not only s…" This reverts commit d827b1b. * Update evaluator/perception_online_evaluator/include/perception_online_evaluator/perception_online_evaluator_node.hpp * Update evaluator/perception_online_evaluator/src/perception_online_evaluator_node.cpp * use emplace back Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Kotaro Uetake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:evaluator
Evaluation tools for planning, localization etc. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7100
is not yet ready to support in driving_log_replayer. so once revert it.