feat(map_based_prediction): use different time horizon #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soblin
requested review from
ktro2828,
kyoichi-sugahara,
takayuki5168,
tkimura4 and
YoshiRi
as code owners
github-actions
bot
added
the
component:perception
Merged
7 tasks
soblin
added
the
run:build-and-test-differential
soblin
changed the title
soblin
changed the title
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
feat/map_based_prediction/different-horizon
branch
from
c8efc11 to
69ebedf
Compare
YoshiRi
reviewed
May 30, 2024
| @@ -106,6 +106,13 @@ struct PredictedRefPath | |||
| Maneuver maneuver; | |||
| }; | |||
|
|
|||
| struct PredictionTimeHorizon | |||
| { | |||
| double vehicle; | |||
There was a problem hiding this comment.
How about add some comment in this description?
We use "vehicle" prediction in motorcycle and "pedestrian" prediction for bicycle for now and this is not obvious to users.
YoshiRi
approved these changes
May 30, 2024
Signed-off-by: Mamoru Sobue <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ation#7157) Signed-off-by: Mamoru Sobue <[email protected]>
4 tasks
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…ation#7157) Signed-off-by: Mamoru Sobue <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for vehicle, use longer prediction time
Related links
https://tier4.atlassian.net/browse/RT1-5447
Tests performed
https://evaluation.tier4.jp/evaluation/reports/5c831c1b-26fe-5879-8d68-66fc58e60d0a?project_id=prd_jt
Notes for reviewers
Interface changes
none
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.