-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pointpainting_fusion): add test for painting util #7169
Merged
YoshiRi
merged 9 commits into
autowarefoundation:main
from
tzhong518:test/pointpainting_fusion/add_test2
Jul 5, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5168fac
add: unit test for inside bbox func
tzhong518 3785eb7
style(pre-commit): autofix
pre-commit-ci[bot] 8678454
Merge branch 'main' into test/pointpainting_fusion/add_test2
tzhong518 99f2254
fix: correct param name
tzhong518 9185829
Merge branch 'test/pointpainting_fusion/add_test2' of github.com:tzho…
tzhong518 7ca9e7b
add: comment
tzhong518 45287ac
Merge branch 'main' into test/pointpainting_fusion/add_test2
tzhong518 4ba58fa
Merge branch 'main' into test/pointpainting_fusion/add_test2
YoshiRi afe57f7
fix: do not run specific test without cuda env
YoshiRi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
perception/image_projection_based_fusion/test/test_pointpainting_fusion.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
// Copyright 2024 TIER IV, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include <image_projection_based_fusion/pointpainting_fusion/node.hpp> | ||
|
||
#include <gtest/gtest.h> | ||
|
||
sensor_msgs::msg::RegionOfInterest createRoi( | ||
const int32_t x_offset, const int32_t y_offset, const int32_t width, const int32_t height) | ||
{ | ||
sensor_msgs::msg::RegionOfInterest roi; | ||
roi.x_offset = x_offset; | ||
roi.y_offset = y_offset; | ||
roi.width = width; | ||
roi.height = height; | ||
return roi; | ||
} | ||
|
||
TEST(isInsideBboxTest, Inside) | ||
{ | ||
const sensor_msgs::msg::RegionOfInterest roi = createRoi(20, 20, 10, 10); | ||
bool result = image_projection_based_fusion::isInsideBbox(25.0, 25.0, roi, 1.0); | ||
EXPECT_TRUE(result); | ||
} | ||
|
||
TEST(isInsideBboxTest, Border) | ||
{ | ||
const sensor_msgs::msg::RegionOfInterest roi = createRoi(20, 20, 10, 10); | ||
bool result = image_projection_based_fusion::isInsideBbox(20.0, 30.0, roi, 1.0); | ||
EXPECT_TRUE(result); | ||
} | ||
|
||
TEST(isInsideBboxTest, Outside) | ||
{ | ||
const sensor_msgs::msg::RegionOfInterest roi = createRoi(20, 20, 10, 10); | ||
bool result = image_projection_based_fusion::isInsideBbox(15.0, 15.0, roi, 1.0); | ||
EXPECT_FALSE(result); | ||
} | ||
|
||
TEST(isInsideBboxTest, Zero) | ||
{ | ||
const sensor_msgs::msg::RegionOfInterest roi = createRoi(0, 0, 0, 0); | ||
bool result = image_projection_based_fusion::isInsideBbox(0.0, 0.0, roi, 1.0); | ||
EXPECT_TRUE(result); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [imo]
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zc means scaling, right?
roi_expand_scale
orscale_factor
How about following expression?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zc means the z-axis value of the pointcloud in the camera coordinate, the formula is commented here. zc is multified to the roi offset to avoid division calculation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I understand your point. Would you mind add comment like below?