Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traffic_light_fine_detector): add const in util function #7172

Closed
wants to merge 2 commits into from

Conversation

Shin-kyoto
Copy link
Contributor

@Shin-kyoto Shin-kyoto commented May 30, 2024

Description

  • Add const in util function.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Shin-kyoto Shin-kyoto requested a review from kminoda May 30, 2024 07:03
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 30, 2024
@Shin-kyoto Shin-kyoto added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels May 30, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 30, 2024
@Shin-kyoto Shin-kyoto marked this pull request as ready for review May 30, 2024 07:33
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3d849e9) to head (982eee4).
Report is 534 commits behind head on main.

Files Patch % Lines
...eption/traffic_light_fine_detector/src/nodelet.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7172       +/-   ##
==========================================
- Coverage   15.09%   0.00%   -15.10%     
==========================================
  Files        1967      71     -1896     
  Lines      135941    4672   -131269     
  Branches    42122     471    -41651     
==========================================
- Hits        20520       0    -20520     
+ Misses      92700    4672    -88028     
+ Partials    22721       0    -22721     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shin-kyoto Shin-kyoto closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants