feat(pose_estimator_arbiter): componentize PoseEstimatorArbiter #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: a-maumau <[email protected]>
Signed-off-by: a-maumau <[email protected]>
github-actions
bot
added
the
component:localization
|
@KYabuuchi It seems running the following command from #6144 ros2 launch autoware_launch logging_simulator.launch.xml \
map_path:=$HOME/MAP vehicle_model:=sample_vehicle sensor_model:=awsim_sensor_kit \
pose_source:=ndt_yabloc_eagleye_artag # or ndt_yabloc, eagleye_artag and so on, the In the launch log, Also, running the test: This also should indicate the node is not running. Do you have any suggestion or solution for this? |
|
@a-maumau I will check soon. Please wait 🙏 |
KYabuuchi
reviewed
May 31, 2024
add namespace Co-authored-by: Kento Yabuuchi <[email protected]>
KYabuuchi
added
the
run:build-and-test-differential
Signed-off-by: a-maumau <[email protected]>
KYabuuchi
approved these changes
May 31, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…warefoundation#7183) * mod to componentize and use glog Signed-off-by: a-maumau <[email protected]> * change log output from screen to both Signed-off-by: a-maumau <[email protected]> * style(pre-commit): autofix * Update localization/pose_estimator_arbiter/CMakeLists.txt add namespace Co-authored-by: Kento Yabuuchi <[email protected]> * remove unusing main func Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kento Yabuuchi <[email protected]>
a-maumau
added a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…warefoundation#7183) * mod to componentize and use glog Signed-off-by: a-maumau <[email protected]> * change log output from screen to both Signed-off-by: a-maumau <[email protected]> * style(pre-commit): autofix * Update localization/pose_estimator_arbiter/CMakeLists.txt add namespace Co-authored-by: Kento Yabuuchi <[email protected]> * remove unusing main func Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kento Yabuuchi <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* mod to componentize and use glog Signed-off-by: a-maumau <[email protected]> * change log output from screen to both Signed-off-by: a-maumau <[email protected]> * style(pre-commit): autofix * Update localization/pose_estimator_arbiter/CMakeLists.txt add namespace Co-authored-by: Kento Yabuuchi <[email protected]> * remove unusing main func Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kento Yabuuchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Componentize the node in localization/pose_estimator_arbiter.
(Add glog feature to localization/pose_estimator_arbiter)
Also, log output is changed from "screen" to "both".
Tests performed
Confirmed that terminating the
pose_estimator_arbiterprocess will output logs to both the terminal and the log file.Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.