Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ar_tag_based_localizer): componentize ArTagBasedLocalizer #7187

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 31, 2024

Description

Componentize the node in localization/landmark_based_localizer/ar_tag_based_localizer.
(Add glog feature to ar_tag_based_localizer)

Also, log output is changed from "log" to "both".

Tests performed

Confirmed that terminating the ar_tag_based_localizer_node process will output logs to both the terminal and the log file.

1717131164.5232539 [ar_tag_based_localizer_node-78] [INFO] [1717131164.522829513] [rclcpp]: signal_handler(signum=15)
1717131164.5233648 [ar_tag_based_localizer_node-78] *** Aborted at 1717131164 (unix time) try "date -d @1717131164" if you are using GNU date ***
1717131164.5249121 [ar_tag_based_localizer_node-78] PC: @                0x0 (unknown)
1717131164.5255859 [ar_tag_based_localizer_node-78] *** SIGTERM (@0x3e8000e1b20) received by PID 2943183 (TID 0x7f1d0a451680) from PID 924448; stack trace: ***
1717131164.5264499 [ar_tag_based_localizer_node-78]     @     0x7f1d0acef4d6 google::(anonymous namespace)::FailureSignalHandler()
1717131164.5276420 [ar_tag_based_localizer_node-78]     @     0x7f1d0ac19ded rclcpp::SignalHandler::signal_handler()
1717131164.5285625 [ar_tag_based_localizer_node-78]     @     0x7f1d0a242520 (unknown)
1717131164.5295334 [ar_tag_based_localizer_node-78]     @     0x7f1d0a291117 (unknown)
1717131164.5304880 [ar_tag_based_localizer_node-78]     @     0x7f1d0a293a41 pthread_cond_wait
1717131164.5313802 [ar_tag_based_localizer_node-78]     @     0x7f1d0a116a8d ddsrt_cond_wait
1717131164.5322790 [ar_tag_based_localizer_node-78]     @     0x7f1d0a116b55 ddsrt_cond_waituntil
1717131164.5332477 [ar_tag_based_localizer_node-78]     @     0x7f1d0a0fd45d (unknown)
1717131164.5342724 [ar_tag_based_localizer_node-78]     @     0x7f1d0a1b974f rmw_wait
1717131164.5353377 [ar_tag_based_localizer_node-78]     @     0x7f1d0a92c848 rcl_wait
1717131164.5365646 [ar_tag_based_localizer_node-78]     @     0x7f1d0ab611b6 rclcpp::Executor::wait_for_work()
1717131164.5377748 [ar_tag_based_localizer_node-78]     @     0x7f1d0ab616d3 rclcpp::Executor::get_next_executable()
1717131164.5395694 [ar_tag_based_localizer_node-78]     @     0x7f1d0ab65c81 rclcpp::executors::SingleThreadedExecutor::spin()
1717131164.5396512 [ar_tag_based_localizer_node-78]     @     0x5556e5313486 main
1717131164.5406103 [ar_tag_based_localizer_node-78]     @     0x7f1d0a229d90 (unknown)
1717131164.5420680 [ar_tag_based_localizer_node-78]     @     0x7f1d0a229e40 __libc_start_main
1717131164.5421560 [ar_tag_based_localizer_node-78]     @     0x5556e5313e35 _start
1717131164.5476253 [ERROR] [ar_tag_based_localizer_node-78]: process has died ...

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 31, 2024
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 31, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator and glog works well.
Thanks a lot 😶‍🌫️

@SakodaShintaro SakodaShintaro merged commit 6932446 into autowarefoundation:main May 31, 2024
34 of 35 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…arefoundation#7187)

* remove unusing main func

Signed-off-by: a-maumau <[email protected]>

* mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* change exec name and change log output from log to both

Signed-off-by: a-maumau <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…arefoundation#7187)

* remove unusing main func

Signed-off-by: a-maumau <[email protected]>

* mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* change exec name and change log output from log to both

Signed-off-by: a-maumau <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@a-maumau a-maumau deleted the mau/feat/localization/ar_tag_based_localizer branch July 22, 2024 06:17
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* remove unusing main func

Signed-off-by: a-maumau <[email protected]>

* mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* change exec name and change log output from log to both

Signed-off-by: a-maumau <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants