Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_height_fitter): componentize MapHeightFitter #7192

Merged

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 31, 2024

Description

Componentize the node in map/map_height_fitter.
(Add glog feature to map_height_fitter)

Also, add log output and change the file name (node.cpp -> map_height_fitter_node.cpp) to match the other packages.

Tests performed

Confirmed that terminating the map_height_fitter process will output logs to both the terminal and the log file.
Since it will not get launched from Autoware, directly launch the package for testing.

1717135375.6562157 [map_height_fitter_node-1] [INFO] [1717135375.655949160] [rclcpp]: signal_handler(signum=15)
1717135375.6563284 [map_height_fitter_node-1] *** Aborted at 1717135375 (unix time) try "date -d @1717135375" if you are using GNU date ***
1717135375.6568561 [map_height_fitter_node-1] PC: @                0x0 (unknown)
1717135375.6570129 [map_height_fitter_node-1] *** SIGTERM (@0x3e8000e1b20) received by PID 3059429 (TID 0x7fd7e3e36680) from PID 924448; stack trace: ***
1717135375.6575503 [map_height_fitter_node-1]     @     0x7fd7e43434d6 google::(anonymous namespace)::FailureSignalHandler()
1717135375.6579626 [map_height_fitter_node-1]     @     0x7fd7e4219ded rclcpp::SignalHandler::signal_handler()
1717135375.6582382 [map_height_fitter_node-1]     @     0x7fd7e3842520 (unknown)
1717135375.6584966 [map_height_fitter_node-1]     @     0x7fd7e3891117 (unknown)
1717135375.6587284 [map_height_fitter_node-1]     @     0x7fd7e38942dd pthread_cond_clockwait
1717135375.6593916 [map_height_fitter_node-1]     @     0x7fd7e4195315 rclcpp::node_interfaces::NodeGraph::wait_for_graph_change()
1717135375.6600718 [map_height_fitter_node-1]     @     0x7fd7e4148d97 rclcpp::ClientBase::wait_for_service_nanoseconds()
1717135375.6607256 [map_height_fitter_node-1]     @     0x7fd7e41bfcc4 rclcpp::AsyncParametersClient::wait_for_service_nanoseconds()
1717135375.6609509 [map_height_fitter_node-1]     @     0x7fd7e2795d11 map_height_fitter::MapHeightFitter::Impl::Impl()
1717135375.6611056 [map_height_fitter_node-1]     @     0x7fd7e27964ce map_height_fitter::MapHeightFitter::MapHeightFitter()
1717135375.6612787 [map_height_fitter_node-1]     @     0x7fd7e27d84f4 rclcpp_components::NodeFactoryTemplate<>::create_node_instance()
1717135375.6614225 [map_height_fitter_node-1]     @     0x561506dff26d main
1717135375.6615837 [map_height_fitter_node-1]     @     0x7fd7e3829d90 (unknown)
1717135375.6618803 [map_height_fitter_node-1]     @     0x7fd7e3829e40 __libc_start_main
1717135375.6619463 [map_height_fitter_node-1]     @     0x561506dffe45 _start
1717135375.6631048 [ERROR] [map_height_fitter_node-1]: process has died ...

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label May 31, 2024
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 31, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakodaShintaro SakodaShintaro enabled auto-merge (squash) May 31, 2024 07:26
@SakodaShintaro SakodaShintaro merged commit 633f9b2 into autowarefoundation:main May 31, 2024
38 of 39 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…tion#7192)

* rename file name and mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* change exec name and add log output both

Signed-off-by: a-maumau <[email protected]>

---------

Signed-off-by: a-maumau <[email protected]>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…tion#7192)

* rename file name and mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* change exec name and add log output both

Signed-off-by: a-maumau <[email protected]>

---------

Signed-off-by: a-maumau <[email protected]>
@a-maumau a-maumau deleted the mau/feat/map/map_height_fitter branch July 22, 2024 06:18
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* rename file name and mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* change exec name and add log output both

Signed-off-by: a-maumau <[email protected]>

---------

Signed-off-by: a-maumau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants