-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map_height_fitter): componentize MapHeightFitter #7192
Merged
SakodaShintaro
merged 3 commits into
autowarefoundation:main
from
a-maumau:mau/feat/map/map_height_fitter
May 31, 2024
Merged
feat(map_height_fitter): componentize MapHeightFitter #7192
SakodaShintaro
merged 3 commits into
autowarefoundation:main
from
a-maumau:mau/feat/map/map_height_fitter
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: a-maumau <[email protected]>
Signed-off-by: a-maumau <[email protected]>
Signed-off-by: a-maumau <[email protected]>
a-maumau
requested review from
anhnv3991,
isamu-takagi,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4 and
YamatoAndo
as code owners
May 31, 2024 06:30
github-actions
bot
added
the
component:map
Map creation, storage, and loading. (auto-assigned)
label
May 31, 2024
isamu-takagi
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SakodaShintaro
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
May 31, 2024
SakodaShintaro
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SakodaShintaro
merged commit May 31, 2024
633f9b2
into
autowarefoundation:main
38 of 39 checks passed
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…tion#7192) * rename file name and mod to componentize and use glog Signed-off-by: a-maumau <[email protected]> * mod to componentize and use glog Signed-off-by: a-maumau <[email protected]> * change exec name and add log output both Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]>
a-maumau
added a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…tion#7192) * rename file name and mod to componentize and use glog Signed-off-by: a-maumau <[email protected]> * mod to componentize and use glog Signed-off-by: a-maumau <[email protected]> * change exec name and add log output both Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* rename file name and mod to componentize and use glog Signed-off-by: a-maumau <[email protected]> * mod to componentize and use glog Signed-off-by: a-maumau <[email protected]> * change exec name and add log output both Signed-off-by: a-maumau <[email protected]> --------- Signed-off-by: a-maumau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:map
Map creation, storage, and loading. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Componentize the node in
map/map_height_fitter
.(Add glog feature to map_height_fitter)
Also, add log output and change the file name (
node.cpp
->map_height_fitter_node.cpp
) to match the other packages.Tests performed
Confirmed that terminating the
map_height_fitter
process will output logs to both the terminal and the log file.Since it will not get launched from Autoware, directly launch the package for testing.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.