-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(map_loader): add log output #7203
fix(map_loader): add log output #7203
Conversation
Signed-off-by: a-maumau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR.
I have confirmed that it works correctly with following command:
ros2 launch map_loader lanelet2_map_loader.launch.xml lanelet2_map_path:=...
ros2 launch map_loader pointcloud_map_loader.launch.xml pointcloud_map_path:=...
I update the PR comment and add a composable node case. It seems it will not output log in log file because map_container's output is set to "screen":
|
42a6340
into
autowarefoundation:main
add log output Signed-off-by: a-maumau <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>
add log output Signed-off-by: a-maumau <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>
add log output Signed-off-by: a-maumau <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>
Description
Add log output to launch file in
map/map_loader
.It is set to "both", which outputs to both the terminal and the log file.
Tests performed
I checked that both the terminal and the log file will receive the log output.
The log file when the running process get killed (launched individually):
Within container (throwing std::runtime_error):
(this will not get logged in log file because map_container is logging with screen)
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.