Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_velocity_smoother): use polling subscriber #7216

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 1, 2024

Description

The same as this PR based on the discussion, the polling subscriber is used in the obstacle_avoidance_planner.

Tests performed

psim

Effects on system behavior

Nothing but more efficient CPU usage

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 1, 2024
@takayuki5168 takayuki5168 force-pushed the feat/use-polling-subscriber-motion-velocity branch from 75d02c1 to 13de706 Compare June 5, 2024 15:18
@takayuki5168 takayuki5168 changed the title feat(motion_velocity_smoother): use polling subscriber feat(autoware_velocity_smoother): use polling subscriber Jun 5, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review June 5, 2024 15:20
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 5, 2024
@takayuki5168
Copy link
Contributor Author

@satoshi-ota @rej55
Can you review the PR?

@takayuki5168 takayuki5168 reopened this Jun 8, 2024
@takayuki5168 takayuki5168 force-pushed the feat/use-polling-subscriber-motion-velocity branch from 13de706 to b7197c9 Compare June 8, 2024 14:23
@takayuki5168 takayuki5168 enabled auto-merge (squash) June 8, 2024 14:25
@takayuki5168 takayuki5168 merged commit 3b036b1 into autowarefoundation:main Jun 8, 2024
22 of 24 checks passed
@takayuki5168 takayuki5168 deleted the feat/use-polling-subscriber-motion-velocity branch June 8, 2024 15:15
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
feat(motion_velocity_smoother): use polling subscriber

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants