Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_velocity_planner): use polling subscriber to efficiently get messages #7223

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jun 3, 2024

Description

Use a polling subscriber for the topics of the motion_velocity_planner, improving the performance of the node.

Tests performed

Psim

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 3, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 3, 2024
@maxime-clem maxime-clem changed the title feat(motion_velocity_planner): use polling subscriber for odometry topic feat(motion_velocity_planner): use polling subscriber to efficiently get messages Jun 3, 2024
@maxime-clem maxime-clem force-pushed the feat/motion_velocity_planner-polling_sub branch from bb09041 to f96271c Compare June 5, 2024 07:02
@maxime-clem maxime-clem force-pushed the feat/motion_velocity_planner-polling_sub branch from f96271c to 6cbbbc0 Compare June 6, 2024 01:18
@takayuki5168 takayuki5168 merged commit 895b07b into autowarefoundation:main Jun 10, 2024
23 of 25 checks passed
@maxime-clem maxime-clem deleted the feat/motion_velocity_planner-polling_sub branch June 10, 2024 02:59
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…get messages (#7223)

* feat(motion_velocity_planner): use polling subscriber for odometry topic

Signed-off-by: Maxime CLEMENT <[email protected]>

* use polling subscribers for more topics

Signed-off-by: Maxime CLEMENT <[email protected]>

* remove blocking mutex lock when processing traffic lights

Signed-off-by: Maxime CLEMENT <[email protected]>

* fix assign after return

Signed-off-by: Maxime CLEMENT <[email protected]>

---------

Signed-off-by: Maxime CLEMENT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants