Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace autoware_auto_msgs with autoware_msgs for localization modules #7243

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Jun 3, 2024

Description

This is subset of #6893 to make it easier to review.
This includes all the modification for localization directory in the original PR.

Related links

#6893
https://github.com/orgs/autowarefoundation/discussions/3862

Tests performed

Notes for reviewers

Interface changes

Message types are modified according to the table in this comment.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Jun 3, 2024
@mitsudome-r mitsudome-r requested a review from xmfcx June 3, 2024 16:27
@xmfcx xmfcx added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 4, 2024
… modules

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
@xmfcx xmfcx force-pushed the autoware_msg_localization branch from 71cf1a0 to 64758d0 Compare June 4, 2024 15:12
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using HADMapBin = autoware_auto_mapping_msgs::msg::HADMapBin;

This is missing, therefore:
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_EXPORT_COMPILE_COMMANDS=1 --packages-up-to ar_tag_based_localizer autoware_pose_covariance_modifier ekf_localizer geo_pose_projector gyro_odometer landmark_manager localization_error_monitor localization_util ndt_scan_matcher pose2twist pose_estimator_arbiter pose_initializer pose_instability_detector stop_filter tree_structured_parzen_estimator twist2accel yabloc_common yabloc_image_processing yabloc_monitor yabloc_particle_filter yabloc_pose_initializer
is failing to compile.

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was on the main branch while testing, compiling again.

@yukkysaito
Copy link
Contributor

yukkysaito commented Jun 4, 2024

In my environment, there is no issue.
There should be no auto_msgs.
image

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_EXPORT_COMPILE_COMMANDS=1 --packages-up-to ar_tag_based_localizer autoware_pose_covariance_modifier ekf_localizer geo_pose_projector gyro_odometer landmark_manager localization_error_monitor localization_util ndt_scan_matcher pose2twist pose_estimator_arbiter pose_initializer pose_instability_detector stop_filter tree_structured_parzen_estimator twist2accel yabloc_common yabloc_image_processing yabloc_monitor yabloc_particle_filter yabloc_pose_initializer

Compiles fine. ✅

@xmfcx xmfcx merged commit f14acc1 into main Jun 4, 2024
27 of 28 checks passed
@xmfcx xmfcx deleted the autoware_msg_localization branch June 4, 2024 15:23
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
… modules (autowarefoundation#7243)

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
… modules (#7243)

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants