-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: replace autoware_auto_msgs with autoware_msgs for localization modules #7243
Conversation
… modules Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]>
71cf1a0
to
64758d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 38 in f2ee838
using HADMapBin = autoware_auto_mapping_msgs::msg::HADMapBin; |
This is missing, therefore:
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_EXPORT_COMPILE_COMMANDS=1 --packages-up-to ar_tag_based_localizer autoware_pose_covariance_modifier ekf_localizer geo_pose_projector gyro_odometer landmark_manager localization_error_monitor localization_util ndt_scan_matcher pose2twist pose_estimator_arbiter pose_initializer pose_instability_detector stop_filter tree_structured_parzen_estimator twist2accel yabloc_common yabloc_image_processing yabloc_monitor yabloc_particle_filter yabloc_pose_initializer
is failing to compile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I was on the main branch while testing, compiling again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_EXPORT_COMPILE_COMMANDS=1 --packages-up-to ar_tag_based_localizer autoware_pose_covariance_modifier ekf_localizer geo_pose_projector gyro_odometer landmark_manager localization_error_monitor localization_util ndt_scan_matcher pose2twist pose_estimator_arbiter pose_initializer pose_instability_detector stop_filter tree_structured_parzen_estimator twist2accel yabloc_common yabloc_image_processing yabloc_monitor yabloc_particle_filter yabloc_pose_initializer
Compiles fine. ✅
… modules (autowarefoundation#7243) Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]>
… modules (#7243) Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]>
Description
This is subset of #6893 to make it easier to review.
This includes all the modification for
localization
directory in the original PR.Related links
#6893
https://github.com/orgs/autowarefoundation/discussions/3862
Tests performed
Notes for reviewers
Interface changes
Message types are modified according to the table in this comment.
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.