feat!: replace autoware_auto_msgs with autoware_msgs for simulator modules #7248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsudome-r
requested review from
soblin,
maxime-clem,
TakaHoribe,
tkimura4,
zulfaqar-azmi-t4 and
yukkysaito
as code owners
github-actions
bot
added
type:documentation
yukkysaito
reviewed
Jun 4, 2024
Comment on lines
-218
to
-222
| /** | ||
| * @brief set current_vehicle_cmd_ptr_ with received message | ||
| */ | ||
| void on_vehicle_cmd(const VehicleControlCommand::ConstSharedPtr msg); | ||
|
|
There was a problem hiding this comment.
Note : This is only a declaration with no implementation.
yukkysaito
approved these changes
Jun 4, 2024
This was referenced Jun 4, 2024
…dules Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]>
xmfcx
force-pushed
the
autoware_msg_simulator
branch
from
cba4711 to
ead0068
Compare
xmfcx
added
run:deploy-docs
|
Depends on: When that one is checked out, it compiles. Will merge it since it is mostly a name/type refactor. Also no _auto_msgs references left in the simulator folder ✅ |
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…dules (autowarefoundation#7248) Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…dules (#7248) Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a subset of #6893 to make it easier to review.
This includes all the modification for
simulatordirectory in the original PR.Related links
#6893
https://github.com/orgs/autowarefoundation/discussions/3862
Tests performed
Notes for reviewers
Interface changes
Message types are modified according to the table in this comment.
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.