Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ndt scan matcher): apply static analysis #7278

Merge branch 'main' into refactor/ndt_scan_matcher/apply_static_analysis

3bf7b79
Select commit
Loading
Failed to load commit list.
Merged

refactor(ndt scan matcher): apply static analysis #7278

Merge branch 'main' into refactor/ndt_scan_matcher/apply_static_analysis
3bf7b79
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 10, 2024 in 50s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method ndt_scan_matcher_core.cpp: NDTScanMatcher::callback_sensor_points_main 🔥

Annotations

Check warning on line 567 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

NDTScanMatcher::callback_sensor_points_main already has high cyclomatic complexity, and now it increases in Lines of Code from 239 to 241. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.