Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_distance_calculator): change to read topic by polling #7316

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Jun 6, 2024

Description

Based on the discussion, change goal_distance_calculator to read topic by polling instead of best_effort callback.

Tests performed

psim test were performed

Effects on system behavior

nothing

Interface changes

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Autumn60 Autumn60 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
@Autumn60 Autumn60 marked this pull request as ready for review June 6, 2024 09:19
@Autumn60 Autumn60 requested a review from taikitanaka3 as a code owner June 6, 2024 09:19
Signed-off-by: Autumn60 <[email protected]>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jun 6, 2024
@shmpwk shmpwk requested review from zusizusi, N-Eiki and shtokuda June 9, 2024 10:47
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Nits
One time sub_route_.takeData() is enough for me.

@Autumn60
Copy link
Contributor Author

@shmpwk

Unified the location where takeData() is called.

However, this code still has room for modification. (e.g., overly wide variable scope).
I have created another PR ( #7434 ) that improves goal_distance_calculator and includes the changes made in this PR.

@Autumn60 Autumn60 closed this Jun 19, 2024
@Autumn60 Autumn60 deleted the feat/goal_distance_calculator/sub_by_polling branch August 20, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants