Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pose_covariance_modifier): fix json schema #7323

Conversation

YamatoAndo
Copy link
Contributor

Description

I have fixed the problem of not being able to see the list of parameters in the readme.

Screenshot from 2024-06-06 19-44-35

https://autowarefoundation.github.io/autoware.universe/main/localization/autoware_pose_covariance_modifier/

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <[email protected]>
@YamatoAndo YamatoAndo added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jun 6, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Jun 6, 2024
@meliketanrikulu
Copy link
Contributor

meliketanrikulu commented Jun 10, 2024

Hello @YamatoAndo . Thanks for your work .
I couldn't understand why the flowchart in the documentation is different from README.md. Do you have any ideas about this? It looks broken.
README.md Flowchart: https://github.com/autowarefoundation/autoware.universe/blob/main/localization/autoware_pose_covariance_modifier/config/pose_covariance_modifier.param.yaml#with-this-package
Documentation Flowchart : https://autowarefoundation.github.io/autoware.universe/pr-7323/localization/autoware_pose_covariance_modifier/#with-this-package

@YamatoAndo
Copy link
Contributor Author

I couldn't understand why the flowchart in the documentation is different from README.md. Do you have any ideas about this? It looks broken.

@meliketanrikulu Sorry, I don't know it. However, it is unrelated to this PR, so please fix it in an other PR

@meliketanrikulu
Copy link
Contributor

I couldn't understand why the flowchart in the documentation is different from README.md. Do you have any ideas about this? It looks broken.

@meliketanrikulu Sorry, I don't know it. However, it is unrelated to this PR, so please fix it in an other PR

Okey @YamatoAndo . Thank you. LGTM . We can merge it. I will create new issue for other problem.

@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 12, 2024
@YamatoAndo YamatoAndo enabled auto-merge (squash) June 12, 2024 08:49
@soblin soblin disabled auto-merge June 12, 2024 09:00
@HansRobo HansRobo enabled auto-merge (squash) June 12, 2024 09:57
@HansRobo HansRobo merged commit 67bfa58 into autowarefoundation:main Jun 12, 2024
24 checks passed
@YamatoAndo YamatoAndo deleted the fix/pose_covariance_modifier/fix_json_schema branch June 13, 2024 05:44
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
fix json schema

Signed-off-by: Yamato Ando <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants