feat(accel_brake_map_calibrator): replace polling takeData function with the callback function #7429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: N-Eiki <[email protected]>
N-Eiki
requested review from
taikitanaka3,
1222-takeshi and
tkimura4
as code owners
github-actions
bot
added
the
component:vehicle
N-Eiki
added
the
run:build-and-test-differential
shmpwk
reviewed
Jun 11, 2024
| @@ -46,10 +46,10 @@ AccelBrakeMapCalibrator::AccelBrakeMapCalibrator(const rclcpp::NodeOptions & nod | |||
| max_accel_ = declare_parameter<double>("max_accel", 5.0); | |||
| min_accel_ = declare_parameter<double>("min_accel", -5.0); | |||
| pedal_to_accel_delay_ = declare_parameter<double>("pedal_to_accel_delay", 0.3); | |||
| max_data_count_ = declare_parameter<int>("max_data_count", 200); | |||
| max_data_count_ = static_cast<int>(declare_parameter<int>("max_data_count", 200)); | |||
There was a problem hiding this comment.
Suggested change
| max_data_count_ = static_cast<int>(declare_parameter<int>("max_data_count", 200)); | |
| max_data_count_ = static_cast<int>(declare_parameter("max_data_count", 200)); |
or max_data_count_ = declare_parameter<int>("max_data_count", 200); ??
Signed-off-by: N-Eiki <[email protected]>
….universe into feat/use_takeData_in_abc
shmpwk
approved these changes
Jun 11, 2024
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…ith the callback function (#7429) * fix : repush to solve conflict Signed-off-by: N-Eiki <[email protected]> * style(pre-commit): autofix * delete duplicated int cast Signed-off-by: N-Eiki <[email protected]> --------- Signed-off-by: N-Eiki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, instead of getting msg in callback, it is changed to get msg using takeData function of polling_subscriber in utils.
Recreate PR from #7282 to handle conflicts happned from this PR merge #7351
Related links
Tests performed
The module works as before. By the way, I only have a rosbag file that was collected with the old messages (autoware_auto_* msgs). I don't have any rosbag files with the new messages (autoware_* msgs). So, I confirmed with the old rosbag file and replaced the messages later.
before with old msg
abc_before.mp4
after with old msg
abc_after.mp4
Notes for reviewers
Interface changes
none
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.