Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pointcloud_preprocessor): add unit test for distortion corrector node #7783

Closed
wants to merge 55 commits into from
Closed

feat(pointcloud_preprocessor): add unit test for distortion corrector node #7783

wants to merge 55 commits into from

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Jul 2, 2024 •
edited
Loading

Description

Unit test for distortion corrector node. Especially for the distortion_corrector.cpp
This PR will open when #7137 is merged.

Tests performed

Build

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-select pointcloud_preprocessor

Test

colcon test --packages-select pointcloud_preprocessor --event-handlers console_cohesion+

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

vividf and others added 30 commits May 16, 2024 12:21
@vividf
add support for 3d distortion correction
5f85981 
Signed-off-by: vividf <[email protected]>
@vividf
Merge branch 'autowarefoundation:main' into feature/support_3d_distro…
f30364f 
…tion_correction
@vividf
change parameter back to default and do small refactor
026edf3 
Signed-off-by: vividf <[email protected]>
@vividf
init version, need to double check
89216a1 
Signed-off-by: vividf <[email protected]>
@vividf
fix the logic error
da8f829 
Signed-off-by: vividf <[email protected]>
@vividf
temporary save, need to delete some code
80d88e1
@vividf
init done, need to check for 3d as time is high
4d96e94 
Signed-off-by: vividf <[email protected]>
@vividf
fix error
b990188 
Signed-off-by: vividf <[email protected]>
@vividf
temporaily save
23e4ab9
@vividf
clean code
3830fe6 
Signed-off-by: vividf <[email protected]>
@vividf
remove unused parameters
bf07078 
Signed-off-by: vividf <[email protected]>
@vividf
fix constructor error
93fa49f 
Signed-off-by: vividf <[email protected]>
@vividf
Merge branch 'autowarefoundation:main' into refactor/distortion_corre…
4b7f9e8 
…ctor_node
@vividf
fix spell errors
4023409 
Signed-off-by: vividf <[email protected]>
@vividf
fix more spell errors
eb420a2 
Signed-off-by: vividf <[email protected]>
@vividf
add undistorter to library
8e8dfb9 
Signed-off-by: vividf <[email protected]>
@vividf
Merge branch 'main' into refactor/distortion_corrector_node
fb8573d
@vividf
fix: fix cmake and change class name
d8bbd59 
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
Update sensing/pointcloud_preprocessor/docs/distortion-corrector.md
0891e2c 
Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: update sensing/pointcloud_preprocessor/docs/distortion-correct…
9f48c47 
…or.md

Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: update sensing/pointcloud_preprocessor/docs/distortion-correct…
a767831 
…or.md

Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: fix company name
ba9b04e 
Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: fix company name
b29bc0f 
Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: fix company name
f57a221 
Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: fix imu to IMU
4ebf4fc 
Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: fix company name
a62f2bd 
Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: remove old naming
aececaf 
Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: change boolean variable naming
c5d7aea 
Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: change boolean variable naming
776aeb0 
Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
@vividf @drwnz
chore: change boolean variable naming
d53f3ab 
Co-authored-by: David Wong <[email protected]>
Signed-off-by: vividf <[email protected]>
vividf and others added 20 commits June 14, 2024 11:22
@vividf
chore: remove brackets
68d5cb9 
Signed-off-by: vividf <[email protected]>
@vividf
chore: fix algorithm
2aad8c0 
Signed-off-by: vividf <[email protected]>
@vividf
chore: remove timestamp_field_name and add default parameter for 3d d…
6d24eba 
…istortion

Signed-off-by: vividf <[email protected]>
@vividf
chore: fix known limits explanation
7d890ac 
Signed-off-by: vividf <[email protected]>
@vividf
feat: add parameter schema and launch file for distortion correction …
4a82886 
…node

Signed-off-by: vividf <[email protected]>
@vividf
chore: fix function name
e432226 
Signed-off-by: vividf <[email protected]>
@vividf
chore: fix IMU function name
c6d9cc1 
Signed-off-by: vividf <[email protected]>
@vividf
chore: fix twist and imu iterator function name
ae6ae5c 
Signed-off-by: vividf <[email protected]>
@vividf
fix: add inline for undistortPointcloud function
39f4f62 
Signed-off-by: vividf <[email protected]>
@vividf
chore: move varialbe to const
b5d74ca 
Signed-off-by: vividf <[email protected]>
@vividf
chore: fix grammar error
51e96be 
Signed-off-by: vividf <[email protected]>
@vividf
fix: fix inline function
76603eb 
Signed-off-by: vividf <[email protected]>
@vividf
chore: solve conflicts
6e32152 
Signed-off-by: vividf <[email protected]>
@vividf
Merge branch 'main' into refactor/distortion_corrector_node
798b82b
@vividf
Merge branch 'main' into refactor/distortion_corrector_node
803b158
@vividf
Merge branch 'main' into refactor/distortion_corrector_node
e969356
@vividf
fix: fix bug in previous code
9fef37b 
Signed-off-by: vividf <[email protected]>
@vividf
feat: add unit test for distortion corrector node
3e57b8a 
Signed-off-by: vividf <[email protected]>
@vividf
chore: fix spell error
2419eab 
Signed-off-by: vividf <[email protected]>
@vividf
Merge branch 'autowarefoundation:main' into feature/distortion_correc…
9288506 
…tor_unit_test
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Jul 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@vividf vividf mentioned this pull request Jul 2, 2024
Closed
7 tasks
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Jul 3, 2024
@vividf vividf closed this Jul 3, 2024
@vividf vividf deleted the feature/distortion_corrector_unit_test branch July 3, 2024 08:20
@vividf
Copy link
Contributor Author

vividf commented Jul 3, 2024

Same PR is created in #7801 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vividf