-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_multi_object_tracker): reduce trigger latency #8657
feat(autoware_multi_object_tracker): reduce trigger latency #8657
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
45fb89a
to
f371a6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8657 +/- ##
==========================================
- Coverage 24.17% 24.17% -0.01%
==========================================
Files 1399 1399
Lines 102126 102142 +16
Branches 38770 38774 +4
==========================================
Hits 24688 24688
- Misses 74940 74956 +16
Partials 2498 2498
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would you mind check my comment?
perception/autoware_multi_object_tracker/src/multi_object_tracker_node.cpp
Outdated
Show resolved
Hide resolved
perception/autoware_multi_object_tracker/src/multi_object_tracker_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
…foundation#8657) * feat: timer-based trigger with phase compensation Signed-off-by: Taekjin LEE <[email protected]> * chore: update comments, name of variable Signed-off-by: Taekjin LEE <[email protected]> * chore: declare min and max publish interval ratios Signed-off-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
implementing autowarefoundation#8657 Signed-off-by: Taekjin LEE <[email protected]>
fix: implementing trigger timing fix implementing autowarefoundation#8657 Signed-off-by: Taekjin LEE <[email protected]>
Description
Reduce latency of the multi object tracker caused by periodic trigger of the process.
First implementation
#6710
Revert of the first implementation
#8277
#8484
Issue: Latency due to the timer trigger cycle (and its phase)
The multi-object-tracker adds 50ms of latency. The latency was increased from 2-5ms to 15-60ms.
The latency is changing on each test.
The reason of additional latency is due to the phase difference between the detected object (after detection and merge) and the multi object tracker timer. The phase delay is determined at the launch time and it is random.
Solution
Bringing back high frequency checker of publish timing.
The new implementation has been changed for stability.
Related links
TIER IV INTERNAL discussion
Reported increased latency after #8277
How was this PR tested?
TIER IV Cloud
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.