feat(behavior_velocity_planner): update velocity factor initialization for run out module #9352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the initialization of the velocity factor in the RunOutModule of the behavior_velocity_planner. The velocity factor is now initialized for the RUN_OUT behavior instead of the ROUTE_OBSTACLE behavior. Signed-off-by: Kyoichi Sugahara <[email protected]>
kyoichi-sugahara
requested review from
kosuke55,
mkuri,
shmpwk,
takayuki5168,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
danielsanchezaran
approved these changes
Nov 18, 2024
kosuke55
approved these changes
Nov 18, 2024
kyoichi-sugahara
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9352 +/- ##
==========================================
- Coverage 28.98% 28.96% -0.02%
==========================================
Files 1426 1432 +6
Lines 108249 108303 +54
Branches 41375 41377 +2
==========================================
+ Hits 31374 31375 +1
- Misses 73741 73794 +53
Partials 3134 3134
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
kyoichi-sugahara
merged commit f070655
into
autowarefoundation:main
31 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should be merged with this PR.
Update the initialization of the velocity factor in the RunOutModule of the behavior_velocity_planner.
The velocity factor is now initialized for the RUN_OUT behavior instead of the ROUTE_OBSTACLE behavior.
Motication of this change is to make it possible to detect when the run_out module is launched via adapi.
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.