Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test clang-tidy pr #9582

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −2
Draft

test clang-tidy pr #9582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ff08a6
test pr
yhisaki Dec 5, 2024
17496c9
update
yhisaki Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-and-test-differential.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ jobs:

- name: Run clang-tidy
if: ${{ steps.get-changed-files.outputs.changed-files != '' }}
uses: autowarefoundation/autoware-github-actions/clang-tidy@v1
uses: autowarefoundation/autoware-github-actions/clang-tidy@clang-tidy-pr-comments
with:
rosdistro: humble
target-packages: ${{ steps.get-modified-packages.outputs.modified-packages }}
Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:

- name: Run clang-tidy
if: ${{ steps.get-changed-files.outputs.changed-files != '' }}
uses: autowarefoundation/autoware-github-actions/clang-tidy@v1
uses: autowarefoundation/autoware-github-actions/clang-tidy@clang-tidy-pr-comments
with:
rosdistro: humble
target-packages: ${{ steps.get-modified-packages.outputs.modified-packages }}
Expand Down
7 changes: 7 additions & 0 deletions common/autoware_time_utils/src/time_utils/time_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@

namespace autoware::time_utils
{

class Hoge

Check failure on line 23 in common/autoware_time_utils/src/time_utils/time_utils.cpp

View workflow job for this annotation

GitHub Actions / cppcheck-differential 

The class 'Hoge' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor]

Check warning on line 23 in common/autoware_time_utils/src/time_utils/time_utils.cpp

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (Hoge)

Check warning on line 23 in common/autoware_time_utils/src/time_utils/time_utils.cpp

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (Hoge)

Check failure on line 23 in common/autoware_time_utils/src/time_utils/time_utils.cpp

View workflow job for this annotation

GitHub Actions / cppcheck-differential 

The class 'Hoge' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor]
{
private:
int a_;

Check failure on line 26 in common/autoware_time_utils/src/time_utils/time_utils.cpp

View workflow job for this annotation

GitHub Actions / cppcheck-differential 

class member 'Hoge::a_' is never used. [unusedStructMember]

Check failure on line 26 in common/autoware_time_utils/src/time_utils/time_utils.cpp

View workflow job for this annotation

GitHub Actions / cppcheck-differential 

class member 'Hoge::a_' is never used. [unusedStructMember]
};

////////////////////////////////////////////////////////////////////////////////
std::chrono::nanoseconds interpolate(
std::chrono::nanoseconds a, std::chrono::nanoseconds b, float t) noexcept
Expand Down
Loading