Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(autoware_behavior_path_start_planner_module): add unit tests for geometric shift pull out planner #9640

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

  1. Added test environment for autoware_behavior_path_start_planner_module
  2. Added TestGeometricPullOut as a friend class to GeometricPullOut class
    • Enabled access to private members from the test class
  3. Added null check for dynamic objects in PullOutPlannerBase::isPullOutPathCollided method
    • Returns false when dynamic_objects is null
    • Prevents crashes in situations where dynamic objects do not exist

Related links

Parent Issue:

  • Link

How was this PR tested?

run colcon test with following command

colcon test --event-handlers console_cohesion+ --packages-select autoware_behavior_path_start_planner_module

get the success result

1: [----------] Global test environment set-up.
1: [----------] 1 test from TestGeometricPullOut
1: [ RUN      ] TestGeometricPullOut.GenerateValidGeometricPullOutPath
1: [INFO 1733912210.143215592] [route_handler]: getMainLanelets: lanelet_sequence = [ids: 4618 4635 ] (getMainLanelets():2025)
1: primitive: 4618
1: preferred_primitive id : 4618
1: primitive: 4635
1: primitive: 7787
1: preferred_primitive id : 4635
1: [       OK ] TestGeometricPullOut.GenerateValidGeometricPullOutPath (473 ms)
1: [----------] 1 test from TestGeometricPullOut (473 ms total)

Notes for reviewers

This PR should be merged before this PR.

Interface changes

None.

Effects on system behavior

None.

…anner and improve collision check

Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 13, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.85%. Comparing base (2127ca8) to head (8018342).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...start_planner_module/src/pull_out_planner_base.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9640      +/-   ##
==========================================
+ Coverage   29.57%   29.85%   +0.27%     
==========================================
  Files        1440     1445       +5     
  Lines      108348   108406      +58     
  Branches    41384    42493    +1109     
==========================================
+ Hits        32049    32360     +311     
+ Misses      73190    72930     -260     
- Partials     3109     3116       +7     
Flag Coverage Δ *Carryforward flag
differential 6.95% <0.00%> (?)
total 29.57% <ø> (ø) Carriedforward from a921f8b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…t_path and update tests

Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara merged commit 86ba21f into autowarefoundation:main Dec 13, 2024
33 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the test/start_planner/generate_geometric_pull_out_path_2 branch December 13, 2024 06:17
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Dec 16, 2024
… geometric shift pull out planner (autowarefoundation#9640)

* feat(behavior_path_planner): add unit tests for geometric pull-out planner and improve collision check

Signed-off-by: kyoichi-sugahara <[email protected]>

* feat(behavior_path_planner): add boolean parameter for divide_pull_out_path and update tests

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants