Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_multi_object_tracker): fix bugprone-errors #9651

Merged
merged 1 commit into from
Dec 16, 2024

fix: bugprone-errors

d701ed8
Select commit
Loading
Failed to load commit list.
Merged

fix(autoware_multi_object_tracker): fix bugprone-errors #9651

fix: bugprone-errors
d701ed8
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Dec 16, 2024 in 1m 1s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.04 (8.75 -> 8.71)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Absence of Expected Change Pattern

  • autoware.universe/perception/autoware_multi_object_tracker/lib/tracker/model/bicycle_tracker.cpp is usually changed with: autoware.universe/perception/autoware_multi_object_tracker/lib/tracker/model/pedestrian_tracker.cpp, autoware.universe/perception/autoware_multi_object_tracker/lib/tracker/model/vehicle_tracker.cpp

Details

✅ Improving Code Health:

  • Complex Conditional bicycle_tracker.cpp: BicycleTracker::measureWithShape

Annotations

Check notice on line 212 in perception/autoware_multi_object_tracker/lib/tracker/model/bicycle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Conditional

BicycleTracker::measureWithShape decreases from 2 complex conditionals with 4 branches to 1 complex conditionals with 5 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.