fix(autoware_probabilistic_occupancy_grid_map): fix bugprone-branch-clone

[kobayu858]

Description

This is a fix based on clang-tidy bugprone-branch-clone error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_fixed.cpp:147:64: error: repeated branch in conditional chain [bugprone-branch-clone,-warnings-as-errors]
    if (raw_pointcloud_angle_bins.at(angle_bin_index).empty()) {
                                                               ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_fixed.cpp:149:6: note: end of the original
    } else if (range > raw_pointcloud_angle_bins.at(angle_bin_index).back().range) {
     ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_fixed.cpp:149:84: note: clone 1 starts here
    } else if (range > raw_pointcloud_angle_bins.at(angle_bin_index).back().range) {
                                                                                   ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_projective.cpp:156:64: error: repeated branch in conditional chain [bugprone-branch-clone,-warnings-as-errors]
    if (raw_pointcloud_angle_bins.at(angle_bin_index).empty()) {
                                                               ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_projective.cpp:158:6: note: end of the original
    } else if (range > raw_pointcloud_angle_bins.at(angle_bin_index).back().range) {
     ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_probabilistic_occupancy_grid_map/lib/costmap_2d/occupancy_grid_map_projective.cpp:158:84: note: clone 1 starts here
    } else if (range > raw_pointcloud_angle_bins.at(angle_bin_index).back().range) {
                                                                                   ^

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 29.88%. Comparing base (86ba21f) to head (a0d2389).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
...p/lib/costmap_2d/occupancy_grid_map_projective.cpp	0.00%	4 Missing ⚠️
...id_map/lib/costmap_2d/occupancy_grid_map_fixed.cpp	50.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9652   +/-   ##
=======================================
  Coverage   29.88%   29.88%           
=======================================
  Files        1440     1440           
  Lines      108347   108353    +6     
  Branches    42467    42470    +3     
=======================================
+ Hits        32376    32379    +3     
- Misses      72730    72736    +6     
+ Partials     3241     3238    -3     

Flag	Coverage Δ		*Carryforward flag
differential	12.11% <25.00%> (?)
total	29.88% <ø> (+<0.01%)	⬆️	Carriedforward from 86ba21f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.