Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(autoware_behavior_path_start_planner_module): add unit tests for shift shift pull out planner #9661

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

  1. Added test environment for autoware_behavior_path_start_planner_module
  2. Added TestShiftPullOut as a friend class to ShiftPullOut class
    • Enabled access to private members from the test class

Related links

Parent Issue:

  • Link

How was this PR tested?

run colcon test with following command

colcon test --event-handlers console_cohesion+ --packages-select autoware_behavior_path_start_planner_module

get the success result

1: [----------] 1 test from TestShiftPullOut
1: [ RUN      ] TestShiftPullOut.GenerateValidShiftPullOutPath
1: [INFO] [route_handler]: getMainLanelets: lanelet_sequence = [ids: 4618 4635 ] (getMainLanelets:2025)
1: primitive: 4618
1: preferred_primitive id : 4618
1: primitive: 4635
1: primitive: 7787
1: preferred_primitive id : 4635
1: [WARN] [behavior_path_planner.path_shifter]: Acc limit is too small to be applied. Tj: -0.631609, Ta: 5.837664, j: -0.237489, a_max: 0.341422, acc_limit: 0.150000 (calc_base_lengths:354)
1: [       OK ] TestShiftPullOut.GenerateValidShiftPullOutPath (281 ms)
1: [----------] 1 test from TestShiftPullOut (281 ms total)

Notes for reviewers

This PR should be merged before this PR.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 35.60831% with 868 lines in your changes missing coverage. Please review.

Project coverage is 31.04%. Comparing base (a85c67b) to head (a0cca9f).
Report is 76 commits behind head on main.

Files with missing lines Patch % Lines
...tem/system_monitor/src/net_monitor/net_monitor.cpp 0.00% 121 Missing ⚠️
..._projection_based_fusion/src/camera_projection.cpp 0.00% 99 Missing ⚠️
...e_multi_object_tracker/lib/object_model/shapes.cpp 0.00% 72 Missing ⚠️
.../motion_utils/factor/planning_factor_interface.hpp 0.00% 47 Missing ⚠️
...re_multi_object_tracker/lib/object_model/types.cpp 0.00% 42 Missing ⚠️
...vior_path_lane_change_module/src/utils/markers.cpp 2.70% 35 Missing and 1 partial ⚠️
...ehavior_path_lane_change_module/src/utils/path.cpp 74.13% 16 Missing and 14 partials ⚠️
...nning/autoware_route_handler/src/route_handler.cpp 38.09% 22 Missing and 4 partials ⚠️
...e_planning_evaluator/src/motion_evaluator_node.cpp 0.00% 25 Missing ⚠️
...planning_evaluator/src/planning_evaluator_node.cpp 10.71% 25 Missing ⚠️
... and 57 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9661      +/-   ##
==========================================
+ Coverage   29.80%   31.04%   +1.23%     
==========================================
  Files        1443     1364      -79     
  Lines      108588   102624    -5964     
  Branches    42652    41480    -1172     
==========================================
- Hits        32369    31860     -509     
+ Misses      73040    67626    -5414     
+ Partials     3179     3138      -41     
Flag Coverage Δ
differential 32.32% <36.11%> (?)
differential-cuda 31.04% <35.60%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kobayu858 and others added 15 commits December 25, 2024 13:33
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
…undation#9659)

* fix: bugprone-error

Signed-off-by: kobayu858 <[email protected]>

* fix: fmt

Signed-off-by: kobayu858 <[email protected]>

* fix: pre-commit

Signed-off-by: kobayu858 <[email protected]>

* fix: pre-commit

Signed-off-by: kobayu858 <[email protected]>

---------

Signed-off-by: kobayu858 <[email protected]>
…warefoundation#9662)

* fix: bugprone-error

Signed-off-by: kobayu858 <[email protected]>

* fix: fmt

Signed-off-by: kobayu858 <[email protected]>

---------

Signed-off-by: kobayu858 <[email protected]>
…he obstacle pointcloud based validator (autowarefoundation#9663)

* chore: add validate_max_distance_m parameter for obstacle_pointcloud_based_validator

Signed-off-by: Taekjin LEE <[email protected]>

* chore: optimize object distance validation in obstacle_pointcloud_validator

Signed-off-by: Taekjin LEE <[email protected]>

* chore: add validate_max_distance_m parameter for obstacle_pointcloud_based_validator

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.