style(pre-commit): autofix
CodeScene PR Check
❌ Quality Gates: FAILED
- Declining Code Health: 9 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Negative Code Health Impact (highest to lowest):
- Large Method ekf_localizer.cpp: EKFLocalizer::EKFLocalizer
- Complex Method ekf_localizer.cpp: EKFLocalizer::timerCallback
- Large Method ekf_localizer.cpp: EKFLocalizer::measurementUpdatePose
- Complex Conditional diagnostics.cpp: checkMeasurementUpdated
- Complex Conditional diagnostics.cpp: checkMeasurementDelayGate
- Complex Conditional diagnostics.cpp: checkMeasurementMahalanobisGate
- Excess Number of Function Arguments diagnostics.cpp: checkMeasurementUpdated
- Excess Number of Function Arguments diagnostics.cpp: checkMeasurementDelayGate
- Excess Number of Function Arguments diagnostics.cpp: checkMeasurementMahalanobisGate
✅ Positive Code Health Impact (highest to lowest):
- Large Method ekf_localizer.cpp: EKFLocalizer::timerCallback
Annotations
Check warning on line 1 in localization/ekf_localizer/src/diagnostics.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
checkMeasurementUpdated has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 1 in localization/ekf_localizer/src/diagnostics.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
checkMeasurementDelayGate has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 1 in localization/ekf_localizer/src/diagnostics.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
checkMeasurementMahalanobisGate has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 1 in localization/ekf_localizer/src/diagnostics.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
checkMeasurementUpdated has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 1 in localization/ekf_localizer/src/diagnostics.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
checkMeasurementDelayGate has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 1 in localization/ekf_localizer/src/diagnostics.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
checkMeasurementMahalanobisGate has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 291 in localization/ekf_localizer/src/ekf_localizer.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
EKFLocalizer::timerCallback has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in localization/ekf_localizer/src/ekf_localizer.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Large Method
EKFLocalizer::timerCallback is no longer above the threshold for lines of code. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 161 in localization/ekf_localizer/src/ekf_localizer.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Large Method
EKFLocalizer::EKFLocalizer has 104 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 555 in localization/ekf_localizer/src/ekf_localizer.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Large Method
EKFLocalizer::measurementUpdatePose has 70 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.