CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Jan 11, 2024 in 1m 0s
CodeScene PR Check
β Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) π©
- Improving Code Health: 0 findings(s) β
- Affected Hotspots: 0 files(s) π₯
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
π© Declining Code Health (highest to lowest):
- Complex Method ring_outlier_filter_nodelet.cpp: RingOutlierFilterComponent::faster_filter
- Complex Method concatenate_and_time_sync_nodelet.cpp: PointCloudConcatenateDataSynchronizerComponent::publish
- Bumpy Road Ahead concatenate_and_time_sync_nodelet.cpp: PointCloudConcatenateDataSynchronizerComponent::publish
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β New issue: Complex Method
PointCloudConcatenateDataSynchronizerComponent::publish has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β New issue: Bumpy Road Ahead
PointCloudConcatenateDataSynchronizerComponent::publish has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
βΉ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 5.55 to 5.82, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β Getting worse: Complex Method
RingOutlierFilterComponent::faster_filter already has high cyclomatic complexity, and now it increases in Lines of Code from 200 to 206. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading