chore(autoware_behavior_path_dynamic_obstacle_avoidance_module): rena…
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
May 30, 2024 in 47s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 5 findings(s) 🚩
- Improving Code Health: 26 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method shift_line_generator.cpp: ShiftLineGenerator::generateAvoidOutline
- Complex Method shift_line_generator.cpp: ShiftLineGenerator::addReturnShiftLine
- Large Method scene.cpp: AvoidanceModule::fillFundamentalData
- Complex Method scene.cpp: AvoidanceModule::isSafePath
- Complex Method scene.cpp: AvoidanceModule::plan
✅ Improving Code Health:
- Deep, Nested Complexity scene.cpp: DynamicAvoidanceModule::calcCollisionSection
- Large Method manager.cpp: DynamicAvoidanceModuleManager::updateModuleParams
- Large Method manager.cpp: DynamicAvoidanceModuleManager::init
- Complex Conditional scene.cpp: DynamicAvoidanceModule::determineWhetherToAvoidAgainstRegulatedObjects
- Complex Conditional scene.cpp: DynamicAvoidanceModule::calcMinMaxLateralOffsetToAvoidRegulatedObject
- Complex Conditional scene.cpp: DynamicAvoidanceModule::calcMinMaxLateralOffsetToAvoidUnregulatedObject
- Complex Conditional scene.cpp: DynamicAvoidanceModule::calcEgoPathBasedDynamicObstaclePolygon
- Complex Method scene.cpp: DynamicAvoidanceModule::determineWhetherToAvoidAgainstRegulatedObjects
- Complex Method scene.cpp: DynamicAvoidanceModule::calcEgoPathBasedDynamicObstaclePolygon
- Complex Method scene.cpp: DynamicAvoidanceModule::registerRegulatedObjects
- Complex Method scene.cpp: DynamicAvoidanceModule::calcValidLengthToAvoid
- Complex Method scene.cpp: DynamicAvoidanceModule::calcMinMaxLateralOffsetToAvoidRegulatedObject
- Complex Method scene.cpp: DynamicAvoidanceModule::getObjectType
- Complex Method scene.cpp: DynamicAvoidanceModule::calcMinMaxLateralOffsetToAvoidUnregulatedObject
- Complex Method scene.cpp: DynamicAvoidanceModule::registerUnregulatedObjects
- Complex Method scene.cpp: DynamicAvoidanceModule::calcPredictedPathBasedDynamicObstaclePolygon
- Complex Method scene.cpp: DynamicAvoidanceModule::determineWhetherToAvoidAgainstUnregulatedObjects
- Complex Method scene.cpp: DynamicAvoidanceModule::plan
- Bumpy Road Ahead scene.cpp: DynamicAvoidanceModule::registerRegulatedObjects
- Bumpy Road Ahead scene.cpp: DynamicAvoidanceModule::registerUnregulatedObjects
- Bumpy Road Ahead scene.cpp: DynamicAvoidanceModule::determineWhetherToAvoidAgainstRegulatedObjects
- Bumpy Road Ahead scene.cpp: DynamicAvoidanceModule::updateRefPathBeforeLaneChange
- Bumpy Road Ahead scene.cpp: DynamicAvoidanceModule::calcCollisionSection
- Bumpy Road Ahead scene.cpp: DynamicAvoidanceModule::willObjectCutOut
- Bumpy Road Ahead scene.cpp: DynamicAvoidanceModule::calcValidLengthToAvoid
- Bumpy Road Ahead scene.cpp: DynamicAvoidanceModule::calcPredictedPathBasedDynamicObstaclePolygon
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1223 to 1234, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
AvoidanceModule::isSafePath already has high cyclomatic complexity, and now it increases in Lines of Code from 81 to 82. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
AvoidanceModule::plan already has high cyclomatic complexity, and now it increases in Lines of Code from 108 to 111. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
AvoidanceModule::fillFundamentalData increases from 76 to 80 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
ShiftLineGenerator::generateAvoidOutline already has high cyclomatic complexity, and now it increases in Lines of Code from 202 to 203. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
ShiftLineGenerator::addReturnShiftLine already has high cyclomatic complexity, and now it increases in Lines of Code from 150 to 152. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1798 to 1799, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Large Method
DynamicAvoidanceModuleManager::updateModuleParams is no longer above the threshold for lines of code. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Large Method
DynamicAvoidanceModuleManager::init is no longer above the threshold for lines of code. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Large Method
DynamicObstacleAvoidanceModuleManager::updateModuleParams has 121 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Large Method
DynamicObstacleAvoidanceModuleManager::init has 96 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::determineWhetherToAvoidAgainstRegulatedObjects is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::calcEgoPathBasedDynamicObstaclePolygon is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::registerRegulatedObjects is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::calcValidLengthToAvoid is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::calcMinMaxLateralOffsetToAvoidRegulatedObject is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::getObjectType is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::calcMinMaxLateralOffsetToAvoidUnregulatedObject is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::registerUnregulatedObjects is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::calcPredictedPathBasedDynamicObstaclePolygon is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::determineWhetherToAvoidAgainstUnregulatedObjects is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
DynamicAvoidanceModule::plan is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Complex Method
DynamicObstacleAvoidanceModule::determineWhetherToAvoidAgainstRegulatedObjects has a cyclomatic complexity of 30, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Complex Method
DynamicObstacleAvoidanceModule::calcEgoPathBasedDynamicObstaclePolygon has a cyclomatic complexity of 20, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Complex Method
DynamicObstacleAvoidanceModule::registerRegulatedObjects has a cyclomatic complexity of 19, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading