feat(docker): add simulator-visualizer container #5411
+254
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkaganozt
added
type:containers
oguzkaganozt
force-pushed
the
openadkit-simulator-visualizer
branch
5 times, most recently
from
c0afed8 to
637d735
Compare
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
oguzkaganozt
force-pushed
the
openadkit-simulator-visualizer
branch
from
637d735 to
f7337c8
Compare
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
youtalk
reviewed
Jan 8, 2025
| - name: Docker meta for autoware:universe-devel | ||
| id: meta-universe-devel | ||
| id: meta-devel |
There was a problem hiding this comment.
I think it should be reverted.
Suggested change
| id: meta-devel | |
| id: meta-universe-devel |
There was a problem hiding this comment.
How about creating a docker-build-and-push-tools action, similar to docker-build-and-push-cuda action, instead of appending to the docker-build-and-push action?
https://github.com/autowarefoundation/autoware/blob/main/.github/actions/docker-build-and-push-cuda/action.yaml
|
|
||
| # Set up VNC password | ||
| RUN mkdir -p ~/.vnc && \ | ||
| echo "openadkit" | vncpasswd -f > ~/.vnc/passwd && \ |
There was a problem hiding this comment.
We don’t want to write the password directly in the Dockerfile. We want to pass it through an environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To enable full development and deployment with containers, a dedicated simulator-visualizer container will be beneficial. This container will include the Tier IV Scenario Simulator, RViz Plugins, all necessary ROS 2 message definitions.
Additionally, it will support VNC and NoVNC so users can visualize the RViz screen remotely.
Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/12582124201
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.