Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SegmentationMask): add instance segmentation message #23

Closed

Conversation

StepTurtle
Copy link

@StepTurtle StepTurtle commented Aug 25, 2024

Description

Add a new message type to send instance segmentation results.

Related links

Parent Issue:

Discussion:

Parent PR:

Tests performed

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Currently, we plan to use this message type at perception camera pipeline.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

StepTurtle and others added 2 commits August 23, 2024 12:57
Signed-off-by: Barış Zeren <[email protected]>

chore: change name

Signed-off-by: Barış Zeren <[email protected]>
@mitsudome-r
Copy link
Member

Note:
This is being discussed in the following discussion thread: https://github.com/orgs/autowarefoundation/discussions/5047

@StepTurtle StepTurtle changed the title feat(SegmentationMask): feat(SegmentationMask): add instance segmentation message Aug 29, 2024
@StepTurtle
Copy link
Author

@xmfcx can you review?

@StepTurtle StepTurtle self-assigned this Sep 17, 2024
@StepTurtle
Copy link
Author

Closing the discussion and PRs as won't do due to a lack of motivation, requests on this topic, and no feedback received for a while.

@amadeuszsz
Copy link

@mitsudome-r
I'm looking on all messages in autoware_internal_msgs and I'm not sure if this repository is best place for SegmentationMask. Shouldn't we place it in autoware_perception_msgs? Sorry, if I missed some comment about architecture/design decision and I'm wrong.

@amadeuszsz
Copy link

@StepTurtle
After discussion, we would like to introduce your new msg into autoware_msgs. Could you open new PR for that package? After that, please update your PRs which depend on this msg type and close this PR.

@mitsudome-r
Copy link
Member

Let me talk with @xmfcx on this during Software WG call.
Generally speaking, autoware_msgs is for inter-component message, and we would like to put messages used internally within a component (perception module in this case) to be placed in this repo.

We are planning to refactor this repository similarly to autoware_msgs so that we have autoware_internal_perception_msgs as well.

@amadeuszsz
Copy link

@mitsudome-r
Understood. Therefore looking forward for an update after next Software WG meeting.

@StepTurtle
Sorry for inconvenience regarding requested change of your msg from my side. With reference to @mitsudome-r comment, please give us a bit time and we will back to you with final design decision. I believe this is the last remaining step to merge RTMDet into autoware.universe.

@xmfcx
Copy link
Contributor

xmfcx commented Dec 11, 2024

Sorry for the delays, I will open up a PR in autoware_internal_msgs to solve this problem.

@xmfcx
Copy link
Contributor

xmfcx commented Dec 12, 2024

@xmfcx xmfcx closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants