Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rviz): fix a bug about visualizing ego model #1257

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

xtk8532704
Copy link
Contributor

@xtk8532704 xtk8532704 commented Dec 2, 2024

Description

Fix a bug that autoware_launch/rviz/planning_bev.rviz can't properly visualize the ego vehicle model.

It seems that there is another bug, which Wakabayashi san may fix in the future.

Tests performed

QuickTestPro:
image

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:ui User interface, user experience, graphical user interfaces. (auto-assigned) labels Dec 2, 2024
Signed-off-by: temkei.kem <[email protected]>
@xtk8532704 xtk8532704 force-pushed the fix-planning-bev-rviz branch from 1e2f936 to 32fee00 Compare December 2, 2024 12:30
@xtk8532704 xtk8532704 marked this pull request as ready for review December 2, 2024 12:31
@xtk8532704 xtk8532704 requested a review from shmpwk December 2, 2024 12:31
@xtk8532704 xtk8532704 enabled auto-merge (squash) December 2, 2024 12:31
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtk8532704 xtk8532704 merged commit 6bbe983 into autowarefoundation:main Dec 2, 2024
13 checks passed
@xtk8532704 xtk8532704 deleted the fix-planning-bev-rviz branch December 2, 2024 12:34
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Dec 3, 2024
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253)

Signed-off-by: yuki-takagi-66 <[email protected]>

* feat(object_lanelet_filter): add configurable margin for object lanel… (autowarefoundation#1210)

feat(object_lanelet_filter): add configurable margin for object lanelet filter

Signed-off-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>

* fix(rviz): fix a bug about visualizing ego model (autowarefoundation#1257)

fix a visulization bug.

Signed-off-by: temkei.kem <[email protected]>

---------

Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: Sebastian Zęderowski <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Co-authored-by: Yuki TAKAGI <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Kem (TiankuiXian) <[email protected]>
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Dec 5, 2024
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253)

Signed-off-by: yuki-takagi-66 <[email protected]>

* feat(object_lanelet_filter): add configurable margin for object lanel… (autowarefoundation#1210)

feat(object_lanelet_filter): add configurable margin for object lanelet filter

Signed-off-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>

* fix(rviz): fix a bug about visualizing ego model (autowarefoundation#1257)

fix a visulization bug.

Signed-off-by: temkei.kem <[email protected]>

* refactor(glog_component): prefix package and namespace with autoware (autowarefoundation#1245)

Signed-off-by: Esteve Fernandez <[email protected]>

* refactor(global_parameter_loader): prefix package and namespace with autoware (autowarefoundation#1246)

Signed-off-by: Esteve Fernandez <[email protected]>

* feat(lane_change): add new lane change parameter (autowarefoundation#1224)

* add minimum prepare duration parameter

Signed-off-by: mohammad alqudah <[email protected]>

* increase min_prepare_duration to 1.0 s

Signed-off-by: mohammad alqudah <[email protected]>

* increase min prepare duration value, add new parameter

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: mohammad alqudah <[email protected]>

---------

Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: Sebastian Zęderowski <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Co-authored-by: Yuki TAKAGI <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Sebastian Zęderowski <[email protected]>
Co-authored-by: Kem (TiankuiXian) <[email protected]>
Co-authored-by: Esteve Fernandez <[email protected]>
Co-authored-by: mkquda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) component:ui User interface, user experience, graphical user interfaces. (auto-assigned) run:build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants