-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rviz): fix a bug about visualizing ego model #1257
Merged
xtk8532704
merged 1 commit into
autowarefoundation:main
from
tier4:fix-planning-bev-rviz
Dec 2, 2024
Merged
fix(rviz): fix a bug about visualizing ego model #1257
xtk8532704
merged 1 commit into
autowarefoundation:main
from
tier4:fix-planning-bev-rviz
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:ui
User interface, user experience, graphical user interfaces. (auto-assigned)
labels
Dec 2, 2024
Signed-off-by: temkei.kem <[email protected]>
xtk8532704
force-pushed
the
fix-planning-bev-rviz
branch
from
December 2, 2024 12:30
1e2f936
to
32fee00
Compare
shmpwk
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yuki-takagi-66
added a commit
to tier4/autoware_launch
that referenced
this pull request
Dec 3, 2024
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253) Signed-off-by: yuki-takagi-66 <[email protected]> * feat(object_lanelet_filter): add configurable margin for object lanel… (autowarefoundation#1210) feat(object_lanelet_filter): add configurable margin for object lanelet filter Signed-off-by: Sebastian Zęderowski <[email protected]> Co-authored-by: Sebastian Zęderowski <[email protected]> * fix(rviz): fix a bug about visualizing ego model (autowarefoundation#1257) fix a visulization bug. Signed-off-by: temkei.kem <[email protected]> --------- Signed-off-by: yuki-takagi-66 <[email protected]> Signed-off-by: Sebastian Zęderowski <[email protected]> Signed-off-by: temkei.kem <[email protected]> Co-authored-by: Yuki TAKAGI <[email protected]> Co-authored-by: Sebastian Zęderowski <[email protected]> Co-authored-by: Sebastian Zęderowski <[email protected]> Co-authored-by: Kem (TiankuiXian) <[email protected]>
yuki-takagi-66
added a commit
to tier4/autoware_launch
that referenced
this pull request
Dec 5, 2024
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253) Signed-off-by: yuki-takagi-66 <[email protected]> * feat(object_lanelet_filter): add configurable margin for object lanel… (autowarefoundation#1210) feat(object_lanelet_filter): add configurable margin for object lanelet filter Signed-off-by: Sebastian Zęderowski <[email protected]> Co-authored-by: Sebastian Zęderowski <[email protected]> * fix(rviz): fix a bug about visualizing ego model (autowarefoundation#1257) fix a visulization bug. Signed-off-by: temkei.kem <[email protected]> * refactor(glog_component): prefix package and namespace with autoware (autowarefoundation#1245) Signed-off-by: Esteve Fernandez <[email protected]> * refactor(global_parameter_loader): prefix package and namespace with autoware (autowarefoundation#1246) Signed-off-by: Esteve Fernandez <[email protected]> * feat(lane_change): add new lane change parameter (autowarefoundation#1224) * add minimum prepare duration parameter Signed-off-by: mohammad alqudah <[email protected]> * increase min_prepare_duration to 1.0 s Signed-off-by: mohammad alqudah <[email protected]> * increase min prepare duration value, add new parameter Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: yuki-takagi-66 <[email protected]> Signed-off-by: Sebastian Zęderowski <[email protected]> Signed-off-by: temkei.kem <[email protected]> Signed-off-by: Esteve Fernandez <[email protected]> Signed-off-by: mohammad alqudah <[email protected]> Co-authored-by: Yuki TAKAGI <[email protected]> Co-authored-by: Sebastian Zęderowski <[email protected]> Co-authored-by: Sebastian Zęderowski <[email protected]> Co-authored-by: Kem (TiankuiXian) <[email protected]> Co-authored-by: Esteve Fernandez <[email protected]> Co-authored-by: mkquda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:ui
User interface, user experience, graphical user interfaces. (auto-assigned)
run:build-and-test-differential
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug that
autoware_launch/rviz/planning_bev.rviz
can't properly visualize the ego vehicle model.It seems that there is another bug, which Wakabayashi san may fix in the future.
Tests performed
QuickTestPro:
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.