Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detection-lidar-model): remove unused iou_nms_target_class_names parameter #1267

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Dec 10, 2024

Description

parameter iou_nms_target_class_names to be removed by PR autowarefoundation/autoware.universe#9595 and autowarefoundation/autoware.universe#9612

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kminoda
Copy link
Contributor

kminoda commented Dec 12, 2024

Please also put the link for the transfusion modification PR

@technolojin technolojin requested a review from kminoda December 12, 2024 02:05
@technolojin technolojin enabled auto-merge (squash) December 12, 2024 02:05
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit 5b4ea05 into autowarefoundation:main Dec 12, 2024
18 checks passed
@technolojin technolojin deleted the fix/centerpoint/remove-iou_nms_target_class_names branch December 12, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants