Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoware_motion_velocity_obstacle_slow_down_module): params for obstacle stop and slow down modules #1330

Merged
merged 3 commits into from
Feb 25, 2025
Merged

feat(autoware_motion_velocity_obstacle_slow_down_module): params for obstacle stop and slow down modules #1330

merged 3 commits into from
Feb 25, 2025

Conversation

PanConChicharron
Copy link
Contributor

Description

Adds params for autowarefoundation/autoware.universe#10112

How was this PR tested?

Results in autowarefoundation/autoware.universe#10112

Notes for reviewers

None.

Effects on system behavior

None.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@PanConChicharron PanConChicharron changed the title feat(autoware_motion_velocity_obstacle_slow_down_module): params for https://github.com/autowarefoundation/autoware.universe/pull/10112 feat(autoware_motion_velocity_obstacle_slow_down_module): params for obstacle stop and slow down modules Feb 17, 2025
@PanConChicharron PanConChicharron added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Feb 17, 2025
@PanConChicharron PanConChicharron force-pushed the arjun.ram/RT1-9227_yaml_changes branch 3 times, most recently from ced38af to 3973230 Compare February 18, 2025 00:04
@PanConChicharron PanConChicharron marked this pull request as ready for review February 18, 2025 00:22
takayuki5168
takayuki5168 reviewed Feb 18, 2025
View reviewed changes
...ning/lane_driving/motion_planning/motion_velocity_planner/motion_velocity_planner.param.yaml Outdated
Comment on lines 12 to 13
slow_down_obstacle_type:
pointcloud: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module-related parameter should be in the module's yaml file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

takayuki5168
takayuki5168 reviewed Feb 18, 2025
View reviewed changes
...ning/lane_driving/motion_planning/motion_velocity_planner/motion_velocity_planner.param.yaml Outdated
stop_obstacle_type:
pointcloud: true

enable_slow_down_planning: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, we can disable the obstacle_slow_down only with this flag, but now, we can do that by setting the following to false.
So please remove enable_slow_down_planning.

autoware_launch/autoware_launch/config/planning/preset/default_preset.yaml

Line 101 in caed5fd

default: "true"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

takayuki5168
takayuki5168 reviewed Feb 18, 2025
View reviewed changes
...ning/lane_driving/motion_planning/motion_velocity_planner/motion_velocity_planner.param.yaml Outdated
@@ -1,5 +1,17 @@
/**:
ros__parameters:
common:
enable_debug_info: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, we use RCLCPP_DEBUG instead of RCLCPP_INFO with enable_debug_info, so please remove this flag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

takayuki5168
takayuki5168 reviewed Feb 18, 2025
View reviewed changes
...ning/lane_driving/motion_planning/motion_velocity_planner/motion_velocity_planner.param.yaml Outdated
@@ -1,5 +1,17 @@
/**:
ros__parameters:
common:
enable_debug_info: false
enable_calculation_time_info: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, we measured the processing time with a library StopWatch, but now we have a new library TimeKeeper which is a wrapper library of the StopWatch.
So, please remove enable_calculation_time_info, and use TimeKeeper instead of the StopWatch in the implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TimeKeeper: https://github.com/autowarefoundation/autoware.universe/tree/main/common/autoware_universe_utils#autowareuniverse_utilstimekeeper

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@PanConChicharron PanConChicharron force-pushed the arjun.ram/RT1-9227_yaml_changes branch 3 times, most recently from 35e45a0 to 46ba281 Compare February 20, 2025 08:10
@PanConChicharron PanConChicharron added component:planning Route planning, decision-making, and navigation. (auto-assigned) and removed type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Feb 20, 2025
@PanConChicharron
Copy link
Contributor Author

Reverting closure

@mergify mergify bot mentioned this pull request Feb 20, 2025
Closed
PanConChicharron and others added 3 commits February 25, 2025 13:08
@PanConChicharron
fix
56b211b 
Signed-off-by: Arjun Jagdish Ram <[email protected]>
@pre-commit-ci @PanConChicharron
style(pre-commit): autofix
4b9026c
@PanConChicharron
fix
1f500e0 
Signed-off-by: Arjun Jagdish Ram <[email protected]>
@PanConChicharron PanConChicharron force-pushed the arjun.ram/RT1-9227_yaml_changes branch from 46ba281 to 1f500e0 Compare February 25, 2025 04:12
@takayuki5168 takayuki5168 merged commit 740164d into autowarefoundation:main Feb 25, 2025
12 of 13 checks passed
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@maxime-clem maxime-clem maxime-clem approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66 yuki-takagi-66 is a code owner

@mkquda mkquda Awaiting requested review from mkquda mkquda is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@yhisaki yhisaki Awaiting requested review from yhisaki yhisaki is a code owner

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PanConChicharron @takayuki5168 @maxime-clem