Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware.rviz): remove initial_pose_button_panel #561

Conversation

YamatoAndo
Copy link
Contributor

Description

autowarefoundation/autoware.universe#4848
rviz reports the following error:

[rviz2-74] [ERROR 1693558088.618417957] [rviz2]: PluginlibFactory: The plugin for class 'tier4_localization_rviz_plugin/InitialPose

This plugin was removed autowarefoundation/autoware.universe#4519.
So I will also remove tier4_localization_rviz_plugin/InitialPoseButtonPanel from the autoware.rviz.

Tests performed

LSim works well without an above error message.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yamato-ando <Yamato ANDO>
@YamatoAndo YamatoAndo enabled auto-merge (squash) September 12, 2023 06:24
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamatoAndo YamatoAndo merged commit 0df78f5 into autowarefoundation:main Sep 12, 2023
8 of 9 checks passed
kminoda pushed a commit to kminoda/autoware_launch that referenced this pull request Sep 13, 2023
danielsanchezaran referenced this pull request in tier4/autoware_launch Sep 21, 2023
Signed-off-by: yamato-ando <Yamato ANDO>
Co-authored-by: yamato-ando <Yamato ANDO>
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants