Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surround_obstacle_checker): disable the surround obstacle checker #603

Closed
wants to merge 1 commit into from

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Sep 28, 2023

Description

During the Planning & Control working group it was decided to disable the surround_obstacle_checker by default.
Original discussion: https://github.com/orgs/autowarefoundation/discussions/3799

Tests performed

Not applicable.

Effects on system behavior

The Autoware vehicle will no longer stop if an obstacle is close to its footprint.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
* feat(rviz): add drivable area visualization

Signed-off-by: yutaka <[email protected]>

* update

Signed-off-by: yutaka <[email protected]>

* change name

Signed-off-by: yutaka <[email protected]>

Signed-off-by: yutaka <[email protected]>
Copy link
Contributor

@mehmetdogru mehmetdogru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxime-clem

What do you say if make this param ⬇️ false instead? So that the node wouldn't be launched as well.

<arg name="use_surround_obstacle_check" default="true"/>

@maxime-clem
Copy link
Contributor Author

@maxime-clem

What do you say if make this param ⬇️ false instead? So that the node wouldn't be launched as well.

<arg name="use_surround_obstacle_check" default="true"/>

I made the alternative PR #685

@maxime-clem maxime-clem deleted the surround_obstacle_checker/disable branch November 22, 2023 02:25
Ericpotato pushed a commit that referenced this pull request Nov 6, 2024
refactor(behavior_path_planner): remove unnecessary parameters (#1172)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants